Gentoo Archives: gentoo-catalyst

From: Matt Turner <mattst88@g.o>
To: gentoo-catalyst@l.g.o
Subject: Re: [gentoo-catalyst] [PATCH 3/8] targets: Inline filesystem-functions.sh
Date: Sat, 02 May 2020 23:19:10
Message-Id: CAEdQ38EHR5rJFgnBoTQeyKwh0bKfz0RTpQd1fjnv+yT74Cghmw@mail.gmail.com
In Reply to: Re: [gentoo-catalyst] [PATCH 3/8] targets: Inline filesystem-functions.sh by Brian Dolbec
1 On Sat, May 2, 2020 at 4:03 PM Brian Dolbec <dolsen@g.o> wrote:
2 >
3 > On Fri, 1 May 2020 18:40:31 -0700
4 > Matt Turner <mattst88@g.o> wrote:
5 >
6 > > Signed-off-by: Matt Turner <mattst88@g.o>
7 > > ---
8 >
9 > Again, no reasoning
10
11 Sorry. I think it's pretty apparent.
12
13 Simple functions that are called only from a single place and exist in
14 a different file should just be inlined.
15
16 Should I just add that to the commit message?

Replies