| 1 |
On 10/6/15 2:41 AM, Brian Dolbec wrote: |
| 2 |
> On Mon, 5 Oct 2015 23:48:07 -0400 |
| 3 |
> Mike Frysinger <vapier@g.o> wrote: |
| 4 |
> |
| 5 |
>> This is a member function of a class, so it must have a |self| |
| 6 |
>> argument first. The current code is clearly broken otherwise. Not |
| 7 |
>> that it seems to matter as there aren't any callers in the current |
| 8 |
>> codebase. --- |
| 9 |
>> catalyst/lock.py | 2 +- |
| 10 |
>> 1 file changed, 1 insertion(+), 1 deletion(-) |
| 11 |
>> |
| 12 |
>> diff --git a/catalyst/lock.py b/catalyst/lock.py |
| 13 |
>> index a6f9d3a..9f954eb 100644 |
| 14 |
>> --- a/catalyst/lock.py |
| 15 |
>> +++ b/catalyst/lock.py |
| 16 |
>> @@ -354,7 +354,7 @@ class LockDir: |
| 17 |
>> return True |
| 18 |
>> return False |
| 19 |
>> |
| 20 |
>> - def hardlink_active(lock): |
| 21 |
>> + def hardlink_active(self, lock): |
| 22 |
>> if not os.path.exists(lock): |
| 23 |
>> return False |
| 24 |
>> |
| 25 |
> |
| 26 |
> :) |
| 27 |
> |
| 28 |
> If you want to re-do all the lock code, go for it. I know Anthony was |
| 29 |
> looking at putting that on to his TODO list. Maybe the two of you can |
| 30 |
> get it all in great shape. |
| 31 |
> |
| 32 |
we should write a separate class for file locking with a timeout. the |
| 33 |
motivation here is bug #519656. I wrote a sketch of what the class |
| 34 |
would do, but I have been more involve with working on GRS and just |
| 35 |
haven't gotten to it. also on the TODO list is to get catalyst using |
| 36 |
cgroup. catalyst just doesn't die well on TERM or INT. with GRS I use |
| 37 |
cgroups and its amazingly clean. one of the best features added to the |
| 38 |
kernel in recent history. |
| 39 |
|
| 40 |
-- |
| 41 |
Anthony G. Basile, Ph.D. |
| 42 |
Gentoo Linux Developer [Hardened] |
| 43 |
E-Mail : blueness@g.o |
| 44 |
GnuPG FP : 1FED FAD9 D82C 52A5 3BAB DC79 9384 FA6E F52D 4BBA |
| 45 |
GnuPG ID : F52D4BBA |
Archives