| 1 |
On Mon, 5 Oct 2015 23:48:07 -0400 |
| 2 |
Mike Frysinger <vapier@g.o> wrote: |
| 3 |
|
| 4 |
> This is a member function of a class, so it must have a |self| |
| 5 |
> argument first. The current code is clearly broken otherwise. Not |
| 6 |
> that it seems to matter as there aren't any callers in the current |
| 7 |
> codebase. --- |
| 8 |
> catalyst/lock.py | 2 +- |
| 9 |
> 1 file changed, 1 insertion(+), 1 deletion(-) |
| 10 |
> |
| 11 |
> diff --git a/catalyst/lock.py b/catalyst/lock.py |
| 12 |
> index a6f9d3a..9f954eb 100644 |
| 13 |
> --- a/catalyst/lock.py |
| 14 |
> +++ b/catalyst/lock.py |
| 15 |
> @@ -354,7 +354,7 @@ class LockDir: |
| 16 |
> return True |
| 17 |
> return False |
| 18 |
> |
| 19 |
> - def hardlink_active(lock): |
| 20 |
> + def hardlink_active(self, lock): |
| 21 |
> if not os.path.exists(lock): |
| 22 |
> return False |
| 23 |
> |
| 24 |
|
| 25 |
:) |
| 26 |
|
| 27 |
If you want to re-do all the lock code, go for it. I know Anthony was |
| 28 |
looking at putting that on to his TODO list. Maybe the two of you can |
| 29 |
get it all in great shape. |
| 30 |
|
| 31 |
-- |
| 32 |
Brian Dolbec <dolsen> |
Archives