Gentoo Archives: gentoo-catalyst

From: Matt Turner <mattst88@g.o>
To: gentoo-catalyst@l.g.o
Subject: Re: [gentoo-catalyst] [PATCH 5/5] Drop PORTDIR from make.conf
Date: Sun, 21 Feb 2021 01:59:06
Message-Id: CAEdQ38E0zMvtgVeHyXqM=N-T1vn_bXis6qEj5E2RQy35SGzSZA@mail.gmail.com
In Reply to: [gentoo-catalyst] [PATCH 5/5] Drop PORTDIR from make.conf by Felix Bier
1 'On Wed, Feb 3, 2021 at 7:45 PM Felix Bier <Felix.Bier@×××××××××××××.com> wrote:
2 >
3 > This commit drops PORTDIR from being included in the generated
4 > make.conf. The variable is no longer needed, since the existing code
5 > will now generate a repos.conf entry for the main repo when needed
6 > (i.e. when the location is non-default, which is the same condition
7 > that was applied for PORTDIR in the code removed by this commit).
8 >
9 > The PORTDIR variable is considered deprecated in favor of
10 > repos.conf entries (reference: https://wiki.gentoo.org/wiki/PORTDIR).
11
12 Thank you! The patches look great. I've committed them.
13
14 > Signed-off-by: Felix Bier <felix.bier@×××××××××××××.com>
15 > ---
16 > These patches are intended for application top of 50ba8aad (current master).
17 > To test for formatting issues, I sent the patches to myself, exported the mails
18 > as mbox files and applied them with git am *mbox.
19
20 I appreciate that!
21
22 For whatever reason I still had some trouble applying them. I ran
23 dos2unix, deleted the 'Content-Transfer-Encoding: base64' header and
24 ran base64 -d on the body and they applied cleanly. Strange.