Gentoo Archives: gentoo-catalyst

From: Matt Turner <mattst88@g.o>
To: gentoo-catalyst@l.g.o
Cc: Matt Turner <mattst88@g.o>
Subject: [gentoo-catalyst] [PATCH 02/37] catalyst: Drop outdated comment
Date: Wed, 21 Oct 2020 00:24:02
Message-Id: 20201021002344.378131-2-mattst88@gentoo.org
In Reply to: [gentoo-catalyst] [PATCH 01/37] catalyst: Use early return to unindent code by Matt Turner
1 We don't use os.system anymore. We pass self.env to Popen, so the
2 comment isn't accurate.
3
4 Signed-off-by: Matt Turner <mattst88@g.o>
5 ---
6 catalyst/base/stagebase.py | 5 -----
7 1 file changed, 5 deletions(-)
8
9 diff --git a/catalyst/base/stagebase.py b/catalyst/base/stagebase.py
10 index 48157837..532f7133 100644
11 --- a/catalyst/base/stagebase.py
12 +++ b/catalyst/base/stagebase.py
13 @@ -1307,11 +1307,6 @@ class StageBase(TargetBase, ClearBase, GenBase):
14 print_traceback=False)
15
16 def setup_environment(self):
17 - """
18 - Modify the current environment. This is an ugly hack that should be
19 - fixed. We need this to use the os.system() call since we can't
20 - specify our own environ
21 - """
22 log.debug('setup_environment(); settings = %r', self.settings)
23 for x in list(self.settings):
24 log.debug('setup_environment(); processing: %s', x)
25 --
26 2.26.2

Replies