| 1 |
On Tue, 20 Oct 2020 17:23:09 -0700 |
| 2 |
Matt Turner <mattst88@g.o> wrote: |
| 3 |
|
| 4 |
> We don't use os.system anymore. We pass self.env to Popen, so the |
| 5 |
> comment isn't accurate. |
| 6 |
> |
| 7 |
> Signed-off-by: Matt Turner <mattst88@g.o> |
| 8 |
> --- |
| 9 |
> catalyst/base/stagebase.py | 5 ----- |
| 10 |
> 1 file changed, 5 deletions(-) |
| 11 |
> |
| 12 |
> diff --git a/catalyst/base/stagebase.py b/catalyst/base/stagebase.py |
| 13 |
> index 48157837..532f7133 100644 |
| 14 |
> --- a/catalyst/base/stagebase.py |
| 15 |
> +++ b/catalyst/base/stagebase.py |
| 16 |
> @@ -1307,11 +1307,6 @@ class StageBase(TargetBase, ClearBase, |
| 17 |
> GenBase): print_traceback=False) |
| 18 |
> |
| 19 |
> def setup_environment(self): |
| 20 |
> - """ |
| 21 |
> - Modify the current environment. This is an ugly hack that |
| 22 |
> should be |
| 23 |
> - fixed. We need this to use the os.system() call since we |
| 24 |
> can't |
| 25 |
> - specify our own environ |
| 26 |
> - """ |
| 27 |
> log.debug('setup_environment(); settings = %r', |
| 28 |
> self.settings) for x in list(self.settings): |
| 29 |
> log.debug('setup_environment(); processing: %s', x) |
| 30 |
|
| 31 |
|
| 32 |
Instead of deleting the entire docstring, change it to reflect the |
| 33 |
correct info. ‌pylint will bitch about the lack of a docstring. |
Archives