1 |
commit: ae2a76261fd7e519bfbb3b8c4b41aa511d039245 |
2 |
Author: Zac Medico <zmedico <AT> gentoo <DOT> org> |
3 |
AuthorDate: Sun Nov 3 20:12:02 2019 +0000 |
4 |
Commit: Zac Medico <zmedico <AT> gentoo <DOT> org> |
5 |
CommitDate: Sun Nov 3 20:14:42 2019 +0000 |
6 |
URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=ae2a7626 |
7 |
|
8 |
Revert "install-qa-check.d: remove check that bans libtool files and static libs from /" |
9 |
|
10 |
This reverts commit 498900e5e51460502d8271f409a4c614a021613b. |
11 |
This change is still being discussed. |
12 |
|
13 |
See: https://archives.gentoo.org/gentoo-portage-dev/message/6e4cfbb0ef9c36dc6511d4f2003cc458 |
14 |
Bug: https://bugs.gentoo.org/699252 |
15 |
Signed-off-by: Zac Medico <zmedico <AT> gentoo.org> |
16 |
|
17 |
bin/install-qa-check.d/80libraries | 10 ++++++++++ |
18 |
1 file changed, 10 insertions(+) |
19 |
|
20 |
diff --git a/bin/install-qa-check.d/80libraries b/bin/install-qa-check.d/80libraries |
21 |
index e59369bf6..d1d2c4fdd 100644 |
22 |
--- a/bin/install-qa-check.d/80libraries |
23 |
+++ b/bin/install-qa-check.d/80libraries |
24 |
@@ -152,6 +152,16 @@ lib_check() { |
25 |
done |
26 |
[[ ${abort} == "yes" ]] && die "add those ldscripts" |
27 |
|
28 |
+ # Make sure people don't store libtool files or static libs in /lib |
29 |
+ f=$(ls "${ED%/}"/lib*/*.{a,la} 2>/dev/null) |
30 |
+ if [[ -n ${f} ]] ; then |
31 |
+ __vecho -ne '\n' |
32 |
+ eqawarn "QA Notice: Excessive files found in the / partition" |
33 |
+ eqawarn "${f}" |
34 |
+ __vecho -ne '\n' |
35 |
+ die "static archives (*.a) and libtool library files (*.la) belong in /usr/lib*, not /lib*" |
36 |
+ fi |
37 |
+ |
38 |
# Verify that the libtool files don't contain bogus $D entries. |
39 |
local abort=no gentoo_bug=no always_overflow=no |
40 |
for a in "${ED%/}"/usr/lib*/*.la ; do |