Gentoo Archives: gentoo-portage-dev

From: William Hubbs <williamh@g.o>
To: gentoo-portage-dev@l.g.o
Cc: qa@g.o, William Hubbs <williamh@g.o>
Subject: [gentoo-portage-dev] [PATCH] install-qa-check.d: remove check that bans libtool files and static libs from /
Date: Sun, 27 Oct 2019 17:41:02
Message-Id: 20191027174007.19928-1-williamh@gentoo.org
1 Most upstreams and build systems do not make this distinction, so this
2 causes unnecessary hacks in ebuilds.
3
4 Signed-off-by: William Hubbs <williamh@g.o>
5 ---
6 bin/install-qa-check.d/80libraries | 10 ----------
7 1 file changed, 10 deletions(-)
8
9 diff --git a/bin/install-qa-check.d/80libraries b/bin/install-qa-check.d/80libraries
10 index d1d2c4fdd..e59369bf6 100644
11 --- a/bin/install-qa-check.d/80libraries
12 +++ b/bin/install-qa-check.d/80libraries
13 @@ -152,16 +152,6 @@ lib_check() {
14 done
15 [[ ${abort} == "yes" ]] && die "add those ldscripts"
16
17 - # Make sure people don't store libtool files or static libs in /lib
18 - f=$(ls "${ED%/}"/lib*/*.{a,la} 2>/dev/null)
19 - if [[ -n ${f} ]] ; then
20 - __vecho -ne '\n'
21 - eqawarn "QA Notice: Excessive files found in the / partition"
22 - eqawarn "${f}"
23 - __vecho -ne '\n'
24 - die "static archives (*.a) and libtool library files (*.la) belong in /usr/lib*, not /lib*"
25 - fi
26 -
27 # Verify that the libtool files don't contain bogus $D entries.
28 local abort=no gentoo_bug=no always_overflow=no
29 for a in "${ED%/}"/usr/lib*/*.la ; do
30 --
31 2.23.0

Replies