Gentoo Archives: gentoo-portage-dev

From: William Hubbs <williamh@g.o>
To: gentoo-portage-dev@l.g.o
Cc: qa@g.o, William Hubbs <williamh@g.o>
Subject: [gentoo-portage-dev] [PATCH] install-qa-check.d: remove check that bans libtool files and static libs from /
Date: Sun, 27 Oct 2019 17:41:02
Message-Id: 20191027174007.19928-1-williamh@gentoo.org
Most upstreams and build systems do not make this distinction, so this
causes unnecessary hacks in ebuilds.

Signed-off-by: William Hubbs <williamh@g.o>
---
 bin/install-qa-check.d/80libraries | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/bin/install-qa-check.d/80libraries b/bin/install-qa-check.d/80libraries
index d1d2c4fdd..e59369bf6 100644
--- a/bin/install-qa-check.d/80libraries
+++ b/bin/install-qa-check.d/80libraries
@@ -152,16 +152,6 @@ lib_check() {
 	done
 	[[ ${abort} == "yes" ]] && die "add those ldscripts"
 
-	# Make sure people don't store libtool files or static libs in /lib
-	f=$(ls "${ED%/}"/lib*/*.{a,la} 2>/dev/null)
-	if [[ -n ${f} ]] ; then
-		__vecho -ne '\n'
-		eqawarn "QA Notice: Excessive files found in the / partition"
-		eqawarn "${f}"
-		__vecho -ne '\n'
-		die "static archives (*.a) and libtool library files (*.la) belong in /usr/lib*, not /lib*"
-	fi
-
 	# Verify that the libtool files don't contain bogus $D entries.
 	local abort=no gentoo_bug=no always_overflow=no
 	for a in "${ED%/}"/usr/lib*/*.la ; do
-- 
2.23.0

Replies