| 1 |
On 10/27/19 10:40 AM, William Hubbs wrote: |
| 2 |
> Most upstreams and build systems do not make this distinction, so this |
| 3 |
> causes unnecessary hacks in ebuilds. |
| 4 |
> |
| 5 |
> Signed-off-by: William Hubbs <williamh@g.o> |
| 6 |
> --- |
| 7 |
> bin/install-qa-check.d/80libraries | 10 ---------- |
| 8 |
> 1 file changed, 10 deletions(-) |
| 9 |
> |
| 10 |
> diff --git a/bin/install-qa-check.d/80libraries b/bin/install-qa-check.d/80libraries |
| 11 |
> index d1d2c4fdd..e59369bf6 100644 |
| 12 |
> --- a/bin/install-qa-check.d/80libraries |
| 13 |
> +++ b/bin/install-qa-check.d/80libraries |
| 14 |
> @@ -152,16 +152,6 @@ lib_check() { |
| 15 |
> done |
| 16 |
> [[ ${abort} == "yes" ]] && die "add those ldscripts" |
| 17 |
> |
| 18 |
> - # Make sure people don't store libtool files or static libs in /lib |
| 19 |
> - f=$(ls "${ED%/}"/lib*/*.{a,la} 2>/dev/null) |
| 20 |
> - if [[ -n ${f} ]] ; then |
| 21 |
> - __vecho -ne '\n' |
| 22 |
> - eqawarn "QA Notice: Excessive files found in the / partition" |
| 23 |
> - eqawarn "${f}" |
| 24 |
> - __vecho -ne '\n' |
| 25 |
> - die "static archives (*.a) and libtool library files (*.la) belong in /usr/lib*, not /lib*" |
| 26 |
> - fi |
| 27 |
> - |
| 28 |
> # Verify that the libtool files don't contain bogus $D entries. |
| 29 |
> local abort=no gentoo_bug=no always_overflow=no |
| 30 |
> for a in "${ED%/}"/usr/lib*/*.la ; do |
| 31 |
> |
| 32 |
|
| 33 |
If we merge this patch then we need to make sure that we fix up the |
| 34 |
later code which currently assumes that *.{a,la} may only exist under |
| 35 |
/usr/lib* directories. |
| 36 |
-- |
| 37 |
Thanks, |
| 38 |
Zac |
Archives