| 1 |
On 11/3/19 12:32 PM, Zac Medico wrote: |
| 2 |
> On 10/27/19 10:40 AM, William Hubbs wrote: |
| 3 |
>> Most upstreams and build systems do not make this distinction, so this |
| 4 |
>> causes unnecessary hacks in ebuilds. |
| 5 |
>> |
| 6 |
>> Signed-off-by: William Hubbs <williamh@g.o> |
| 7 |
>> --- |
| 8 |
>> bin/install-qa-check.d/80libraries | 10 ---------- |
| 9 |
>> 1 file changed, 10 deletions(-) |
| 10 |
>> |
| 11 |
>> diff --git a/bin/install-qa-check.d/80libraries b/bin/install-qa-check.d/80libraries |
| 12 |
>> index d1d2c4fdd..e59369bf6 100644 |
| 13 |
>> --- a/bin/install-qa-check.d/80libraries |
| 14 |
>> +++ b/bin/install-qa-check.d/80libraries |
| 15 |
>> @@ -152,16 +152,6 @@ lib_check() { |
| 16 |
>> done |
| 17 |
>> [[ ${abort} == "yes" ]] && die "add those ldscripts" |
| 18 |
>> |
| 19 |
>> - # Make sure people don't store libtool files or static libs in /lib |
| 20 |
>> - f=$(ls "${ED%/}"/lib*/*.{a,la} 2>/dev/null) |
| 21 |
>> - if [[ -n ${f} ]] ; then |
| 22 |
>> - __vecho -ne '\n' |
| 23 |
>> - eqawarn "QA Notice: Excessive files found in the / partition" |
| 24 |
>> - eqawarn "${f}" |
| 25 |
>> - __vecho -ne '\n' |
| 26 |
>> - die "static archives (*.a) and libtool library files (*.la) belong in /usr/lib*, not /lib*" |
| 27 |
>> - fi |
| 28 |
>> - |
| 29 |
>> # Verify that the libtool files don't contain bogus $D entries. |
| 30 |
>> local abort=no gentoo_bug=no always_overflow=no |
| 31 |
>> for a in "${ED%/}"/usr/lib*/*.la ; do |
| 32 |
>> |
| 33 |
> |
| 34 |
> If we merge this patch then we need to make sure that we fix up the |
| 35 |
> later code which currently assumes that *.{a,la} may only exist under |
| 36 |
> /usr/lib* directories. |
| 37 |
> |
| 38 |
|
| 39 |
We should also review the assertion that comes just before, involving |
| 40 |
/usr/lib*/*.a and gen_usr_ldscript. |
| 41 |
-- |
| 42 |
Thanks, |
| 43 |
Zac |
Archives