Re: [gentoo-dev] Re: Proposal: pre-emerge advisories

[Georgi Georgiev]

maillog: 25/07/2005-22:33:09(+0900): Jason Stubbs types
> On Monday 25 July 2005 22:09, Martin Schlemmer wrote:
> > On Mon, 2005-07-25 at 20:53 +0900, Jason Stubbs wrote:
> > > On Monday 25 July 2005 16:51, Martin Schlemmer wrote:
> > > > Something like this maybe?  (Yes, I know using $T will be frowned upon,
> > > > but not much else you can do.  Also, might use has_version(), but that
> > > > is more difficult to parse, and I figured you normally only want those
> > > > for system udev ...)
> > >
> > > Combining the pkg_preinst and pkg_postinst parts (and removing the usage
> > > of $T ;), that pretty much shows exactly what the proposed pkg_warn would
> > > look like. Only difference being that it would be executed before emerging
> > > starts.
> >
> > Currently:
> > - if everything is moved to pkg_preinst(), the message will not show at
> > the end of the merge, so much higher chance of getting missed.
> > - if everything is moved to pkg_postinst(), $udev_version will be the
> > new version, and be of no use.
> > - if you meant that this is for the pkg_warn() ... it still wont really
> > help that much, as it will differ from before/after the update :/
>
> What's the issue with pkg_warn? It would only be ran before the update,
> so the ebuild it's in is the new version and the current version can be
> obtained with has_version.

So,

if $(has_version "<sys-fs/udev-046"); then
	ewarn
fi

...

if $(has_version "<sys-fs/udev-059"); then
	ewarn
fi

For gaim maybe something like this:

+if ! $(has_version "~${PV}" ); then
     ewarn
-    ewarn "If you are merging ${P} from an earlier version, you may need"
-    ewarn "to re-merge any plugins like gaim-encryption or gaim-snpp."
+    ewarn "You may need to re-merge any plugins like gaim-encryption or gaim-snpp."


Maybe a function in an eclass can make this easier on people?

if $(package_is "<" 046); then
...

and package_is (name derived from kernel_is, don't flame the name, it is
for illustration only) could be something like this:

package_is() {
    return $(has_version "${1}${CATEGORY}/${PN}-${2}")
}

That should be good enough for all packages, right?

One more thing. has_version would not necessarily detect the version we
are upgrading from (i.e., the version that will be removed after
installation) if there is a slotted package. Could that become a
problem?

-- 
()   Georgi Georgiev   () Who is D.B. Cooper, and where is he now?     ()
()    chutz@×××.net    ()                                              ()
()  [phone]   ()                                              ()