| 1 |
On Mon, 29 Aug 2011 09:39:16 +0200 |
| 2 |
Tomáš Chvátal <scarabeus@g.o> wrote: |
| 3 |
|
| 4 |
> >> # @ECLASS-VARIABLE: OOO_EXTENSIONS |
| 5 |
> >> # @REQUIRED |
| 6 |
> >> # @DEFAULT_UNSET |
| 7 |
> > |
| 8 |
> > I don't think you're supposed to mix these two. |
| 9 |
> Why? It make perfect sense, it is both required and empty by default. |
| 10 |
|
| 11 |
It is redundant. If a variable is required to be set, then its default |
| 12 |
value shouldn't even be set. Look at eclass-to-manpage.awk, @REQUIRED |
| 13 |
is perfectly enough. |
| 14 |
|
| 15 |
> >> die "Could not determine office implementation!" |
| 16 |
> > |
| 17 |
> > That sounds weird. |
| 18 |
> Why, it returns in the loop above that or thigger this code. |
| 19 |
> I consider it nicer than adding yet another useless condition. |
| 20 |
|
| 21 |
I mean the message text, 'office implementation' :D. KOffice may be |
| 22 |
an 'office implementation' as well. |
| 23 |
|
| 24 |
> > I think you should use local scope if you're intending to use |
| 25 |
> > 'insinto'. |
| 26 |
> > |
| 27 |
> What? I really don't get this :) |
| 28 |
|
| 29 |
Because caller can have his/her own 'insinto' and yours is going to |
| 30 |
override that. Look at do* in eutils.eclass. |
| 31 |
|
| 32 |
-- |
| 33 |
Best regards, |
| 34 |
Michał Górny |
Archives