Gentoo Archives: gentoo-dev

From: Ian Delaney <idella4@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/
Date: Fri, 13 May 2016 08:52:47
Message-Id: 20160513165209.14459685@archtester.homenetwork
In Reply to: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/ by "Michał Górny"
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA512
3
4 On Sat, 7 May 2016 23:25:58 +0200
5 Michał Górny <mgorny@g.o> wrote:
6
7 > On Sat, 7 May 2016 21:19:31 +0000 (UTC)
8 > "Joerg Bornkessel" <hd_brummy@g.o> wrote:
9 >
10 > > commit: 66afcab271f65b97330e610040ad3acc1b812a03
11 > > Author: Joerg Bornkessel <hd_brummy <AT> gentoo <DOT> org>
12 > > AuthorDate: Sat May 7 21:18:48 2016 +0000
13 > > Commit: Joerg Bornkessel <hd_brummy <AT> gentoo <DOT> org>
14 > > CommitDate: Sat May 7 21:18:48 2016 +0000
15 > > URL:
16 > > https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=66afcab2
17 > >
18 > > fixed einstall vs. emake install for eapi=6
19 > >
20 > > eclass/vdr-plugin-2.eclass | 6 +++++-
21 > > 1 file changed, 5 insertions(+), 1 deletion(-)
22 > >
23 > > diff --git a/eclass/vdr-plugin-2.eclass b/eclass/vdr-plugin-2.eclass
24 > > index ae09a34..65f1409 100644
25 > > --- a/eclass/vdr-plugin-2.eclass
26 > > +++ b/eclass/vdr-plugin-2.eclass
27 > > @@ -571,7 +571,11 @@ vdr-plugin-2_src_install() {
28 > > local SOFILE_STRING=$(grep SOFILE Makefile)
29 > > if [[ -n ${SOFILE_STRING} ]]; then
30 > > BUILD_TARGETS=${BUILD_TARGETS:-${VDRPLUGIN_MAKE_TARGET:-install }}
31 > > - einstall ${BUILD_PARAMS} \
32 > > + if [[ ${EAPI} == 6 ]]; then
33 > > + emake install ${BUILD_PARAMS} \
34 > > + else
35 > > + einstall ${BUILD_PARAMS} \
36 > > + fi
37 > > ${BUILD_TARGETS} \
38 > > TMPDIR="${T}" \
39 > > DESTDIR="${D}" \
40 > >
41 >
42 > Do you seriously expect this code to work? How about testing? Or
43 > reading diffs before committing?
44 >
45
46 Do you seriously expect us to sit and absorb this form of pious
47 put down? From one who knows far better who is entitled to speak down
48 to colleagues as is completely lacking a cerebral cortex? Those times
49 are drawing to an end. Did anyone ever teach you to treat folk in such
50 manner and expect them to respect it? I don't think so
51 Not over my dead cvs perhaps
52
53 - --
54 kind regards
55
56 Ian Delaney
57 -----BEGIN PGP SIGNATURE-----
58 Version: GnuPG v2.1
59
60 iQJ8BAEBCgBmBQJXNZW5XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
61 ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRCRUI4RjAxNzRGRTVDMjI4RjcxNkRFNzIw
62 QzQzN0NCNDcxRTlEMzNBAAoJEAxDfLRx6dM6mzcP/1BmrZw/EiuPlJh6MuufJ1/U
63 Zlg26d99Vvvji0VVHcz9lrDhk6ubYB3WrcrG3E2M1pVwXDTuy+z5ez7RXvuUMSSY
64 XiP4uWVWmlQoBlkAzAAvzKKVNsQvfOCif1x/b59Qjm9qAKQOwawTzCjOCHIrB08V
65 EXFuuo5gpHfkq5vtU7jK22/6Zo56w+A7xfgSKl96byepA4F++3vDH4kX3XTBVmtE
66 vlPn230CQqgP/YMZ/TBcQ4AE3r0fxPmGnAniZn/o5v2Zpzo1SZjrRlYJXDq3PnIa
67 Rjs6fWEvfA7xu8wDt05Xz+8bzVXmS//1ga0VB1dmcNlVelUY7Pwi1kR+nUF174Vo
68 /xLlTvK/EboliAMbviRwX9extWycWCB+iyBH/RkazaQQmSiW5tHlVPx8Wu7LiRay
69 O8eFks7LgenetNBymMaiPBNZJMo/I+Fnebk43qx0XfUyuANLsg3JnsY4WG+Evcjc
70 3XqkTePuDyFLQEgQlU417JSFRkyZ0odMqpVShqOxgv4EA/HAiCpWCHkE1ZuiLi1V
71 7bKQodOclD3jTmy6eJgLpoEhqphXCaX9bl5QcFyu3+La8r3YXOqErCbOECoJy0Np
72 lXwOCKZ9kvcv8iLygxKqP/0rxuAP0kzs5NSWd2zhHLRBihNvP+xkc2Pi4ztRT2LN
73 Hju+wa0/WdLLTEPCAe78
74 =4iJI
75 -----END PGP SIGNATURE-----

Replies