| 1 |
On Sat, 7 May 2016 21:19:31 +0000 (UTC) |
| 2 |
"Joerg Bornkessel" <hd_brummy@g.o> wrote: |
| 3 |
|
| 4 |
> commit: 66afcab271f65b97330e610040ad3acc1b812a03 |
| 5 |
> Author: Joerg Bornkessel <hd_brummy <AT> gentoo <DOT> org> |
| 6 |
> AuthorDate: Sat May 7 21:18:48 2016 +0000 |
| 7 |
> Commit: Joerg Bornkessel <hd_brummy <AT> gentoo <DOT> org> |
| 8 |
> CommitDate: Sat May 7 21:18:48 2016 +0000 |
| 9 |
> URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=66afcab2 |
| 10 |
> |
| 11 |
> fixed einstall vs. emake install for eapi=6 |
| 12 |
> |
| 13 |
> eclass/vdr-plugin-2.eclass | 6 +++++- |
| 14 |
> 1 file changed, 5 insertions(+), 1 deletion(-) |
| 15 |
> |
| 16 |
> diff --git a/eclass/vdr-plugin-2.eclass b/eclass/vdr-plugin-2.eclass |
| 17 |
> index ae09a34..65f1409 100644 |
| 18 |
> --- a/eclass/vdr-plugin-2.eclass |
| 19 |
> +++ b/eclass/vdr-plugin-2.eclass |
| 20 |
> @@ -571,7 +571,11 @@ vdr-plugin-2_src_install() { |
| 21 |
> local SOFILE_STRING=$(grep SOFILE Makefile) |
| 22 |
> if [[ -n ${SOFILE_STRING} ]]; then |
| 23 |
> BUILD_TARGETS=${BUILD_TARGETS:-${VDRPLUGIN_MAKE_TARGET:-install }} |
| 24 |
> - einstall ${BUILD_PARAMS} \ |
| 25 |
> + if [[ ${EAPI} == 6 ]]; then |
| 26 |
> + emake install ${BUILD_PARAMS} \ |
| 27 |
> + else |
| 28 |
> + einstall ${BUILD_PARAMS} \ |
| 29 |
> + fi |
| 30 |
> ${BUILD_TARGETS} \ |
| 31 |
> TMPDIR="${T}" \ |
| 32 |
> DESTDIR="${D}" \ |
| 33 |
> |
| 34 |
|
| 35 |
Do you seriously expect this code to work? How about testing? Or |
| 36 |
reading diffs before committing? |
| 37 |
|
| 38 |
-- |
| 39 |
Best regards, |
| 40 |
Michał Górny |
| 41 |
<http://dev.gentoo.org/~mgorny/> |
Archives