[gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

[Ryan Hill]

On Sat, 7 May 2016 23:25:58 +0200
Michał Górny <mgorny@g.o> wrote:

> On Sat,  7 May 2016 21:19:31 +0000 (UTC)
> "Joerg Bornkessel" <hd_brummy@g.o> wrote:
>
> > commit:     66afcab271f65b97330e610040ad3acc1b812a03
> > Author:     Joerg Bornkessel <hd_brummy <AT> gentoo <DOT> org>
> > AuthorDate: Sat May  7 21:18:48 2016 +0000
> > Commit:     Joerg Bornkessel <hd_brummy <AT> gentoo <DOT> org>
> > CommitDate: Sat May  7 21:18:48 2016 +0000
> > URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=66afcab2
> >
> > fixed einstall vs. emake install for eapi=6
> >
> >  eclass/vdr-plugin-2.eclass | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/eclass/vdr-plugin-2.eclass b/eclass/vdr-plugin-2.eclass
> > index ae09a34..65f1409 100644
> > --- a/eclass/vdr-plugin-2.eclass
> > +++ b/eclass/vdr-plugin-2.eclass
> > @@ -571,7 +571,11 @@ vdr-plugin-2_src_install() {
> >  	local SOFILE_STRING=$(grep SOFILE Makefile)
> >  	if [[ -n ${SOFILE_STRING} ]]; then
> >  		BUILD_TARGETS=${BUILD_TARGETS:-${VDRPLUGIN_MAKE_TARGET:-install }}
> > -		einstall ${BUILD_PARAMS} \
> > +		if [[ ${EAPI} == 6 ]]; then
> > +			emake install ${BUILD_PARAMS} \
> > +		else
> > +			einstall ${BUILD_PARAMS} \
> > +		fi
> >  			${BUILD_TARGETS} \
> >  			TMPDIR="${T}" \
> >  			DESTDIR="${D}" \
> >
>
> Do you seriously expect this code to work? How about testing? Or
> reading diffs before committing?

I reverted this commit since it broke sourcing any ebuild inheriting the eclass.

I'm going to assume this commit was made by accident, since any dev that would
commit code to an eclass without testing that it works, or even that it's
_valid bash_, would not continue to have unsupervised commit rights for very
long.


--