Re: [gentoo-dev] [PATCH] go-module.eclass: undeprecate EGO_SUM

[Andrew Ammerlaan]

On 13/06/2022 09:44, Florian Schmaus wrote:
> Following the gentoo-dev@ mailing list discussion [1], this
> un-deprecates EGO_SUM.
>
> 1: https://archives.gentoo.org/gentoo-dev/message/1a64a8e7694c3ee11cd48a58a95f2faa
>
> Signed-off-by: Florian Schmaus <flow@g.o>
> ---
>   eclass/go-module.eclass | 30 +++++++++++-------------------
>   1 file changed, 11 insertions(+), 19 deletions(-)
>
> diff --git a/eclass/go-module.eclass b/eclass/go-module.eclass
> index a5dafb45cab8..2e0b7dc1726d 100644
> --- a/eclass/go-module.eclass
> +++ b/eclass/go-module.eclass
> @@ -25,7 +25,9 @@
>   #
>   # If the software has a directory named vendor in its
>   # top level directory, the only thing you need to do is inherit the
> -# eclass. If it doesn't, you need to also create a dependency tarball and
> +# eclass. If it doesn't, then you either 1) populate EGO_SUM in the ebuild and
> +# call go-module_set_globals as discussed below or 2) you need to create a
> +# dependency tarball and
>   # host it somewhere, for example in your dev space.
>   #
>   # Here is an example of how to create a dependency tarball.

I agree that EGO_SUM shouldn't have been completely deprecated following 
the previous discussion. It is not always possible or practical to host 
a dependency tarball, especially for people who aren't Gentoo 
developers. However, from what I remember from the previous discussion 
there actually were some good arguments against using EGO_SUM, mainly 
relating to the size of the ebuilds and manifests. So perhaps we can 
find some middle ground here and keep EGO_SUM for e.g. third-party 
repositories, while recommending dependency tarballs for use in 
::gentoo. Could we add something among those lines to the text here?

Best regards,
Andrew