Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] glep-0074: Remove single filesystem limitation
Date: Thu, 08 Feb 2018 17:50:33
Message-Id: 1518112224.1303.1.camel@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH] glep-0074: Remove single filesystem limitation by "M. J. Everitt"
1 W dniu czw, 08.02.2018 o godzinie 17∶25 +0000, użytkownik M. J. Everitt
2 napisał:
3 > On 08/02/18 17:09, Michał Górny wrote:
4 > > Remove the limitation that all files covered by the Manifest must reside
5 > > on a single filesystem. This breaks valid uses of overlayfs without
6 > > providing any real advantage.
7 > >
8 > > The removal is justified further in the updated rationale section.
9 > > ---
10 > > glep-0074.rst | 66 +++++++++++++++++++++++++++++++++++------------------------
11 > > 1 file changed, 39 insertions(+), 27 deletions(-)
12 > >
13 > > RST: https://dev.gentoo.org/~mgorny/tmp/glep-0074.rst
14 > > HTML: https://dev.gentoo.org/~mgorny/tmp/glep-0074.html
15 > >
16 > > diff --git a/glep-0074.rst b/glep-0074.rst
17 > > index 3835247..2f8deb2 100644
18 > > --- a/glep-0074.rst
19 > > +++ b/glep-0074.rst
20 > > @@ -6,10 +6,10 @@ Author: Michał Górny <mgorny@g.o>,
21 > > Ulrich Müller <ulm@g.o>
22 > > Type: Standards Track
23 > > Status: Final
24 > > -Version: 1
25 > > +Version: 1.1
26 > > Created: 2017-10-21
27 > > -Last-Modified: 2017-12-16
28 > > -Post-History: 2017-10-26, 2017-11-16
29 > > +Last-Modified: 2018-02-08
30 > > +Post-History: 2017-10-26, 2017-11-16, 2018-02-08
31 > > Content-Type: text/x-rst
32 > > Requires: 59, 61
33 > > Replaces: 44, 58, 60
34 > > @@ -126,13 +126,6 @@ a different file type. If the tree contain files of other types
35 > > that are not otherwise ignored, they need to be covered by an explicit
36 > > ``IGNORE``.
37 > >
38 > > -All the local (non-``DIST``) files covered by a Manifest tree must
39 > > -reside on the same filesystem. It is an error to specify entries
40 > > -applying to files on another filesystem. If files or directories that
41 > > -are not otherwise ignored reside on a different filesystem, or symbolic
42 > > -links point to targets on a different filesystem, they must
43 > > -be explicitly excluded via ``IGNORE``.
44 > > -
45 > >
46 > > Path and filename encoding
47 > > --------------------------
48 > > @@ -325,22 +318,18 @@ Algorithm for finding parent Manifests
49 > > In order to find the top-level Manifest from the current directory
50 > > the following algorithm can be used:
51 > >
52 > > -1. Store the current directory as *original* and the device ID
53 > > - of the containing filesystem (``st_dev``) as *startdev*,
54 > > -
55 > > -2. If the device ID of the containing filesystem (``st_dev``)
56 > > - of the current directory is different than *startdev*, stop.
57 > > +1. Store the current directory as *original*,
58 > >
59 > > -3. If the current directory contains a ``Manifest`` file:
60 > > +2. If the current directory contains a ``Manifest`` file:
61 > >
62 > > a. If an ``IGNORE`` entry in the ``Manifest`` file covers
63 > > the *original* directory (or one of the parent directories), stop.
64 > >
65 > > b. Otherwise, store the current directory as *last_found*.
66 > >
67 > > -4. If the current directory is the root system directory (``/``), stop.
68 > > +3. If the current directory is the root system directory (``/``), stop.
69 > >
70 > > -5. Otherwise, enter the parent directory and jump to step 2.
71 > > +4. Otherwise, enter the parent directory and jump to step 2.
72 > >
73 > > Once the algorithm stops, *last_found* will contain the relevant
74 > > top-level Manifest. If *last_found* is null, then the directory tree
75 > >
76 >
77 > <snip>
78 >
79 > Observation: does RST not support auto-numbering like other formats? It
80 > would make renumbering lists like this much easier (and from programming
81 > experience, less error-prone). If not, #FEATUREREQ ... :]
82
83 The whole purpose of WYWIWYG is to write *proper* text and not some
84 magical syntax that magically gets transformed to auto-numbered list.
85 Except when the format doesn't get it right.
86
87 Also, this comment is entirely off-topic and not useful to the thread
88 at all. Please cease those pointless off-topics.
89
90 --
91 Best regards,
92 Michał Górny