| 1 |
On Monday 01 October 2007, Roy Marples wrote: |
| 2 |
> On Monday 01 October 2007 23:41:36 Fernando J. Pereda wrote: |
| 3 |
> > I sure as hell am not going to proof read all that (mainly because I |
| 4 |
> > think not using bash features in an environment where bash is required |
| 5 |
> > is silly, instead of being an improvement) |
| 6 |
> |
| 7 |
> OK. Maybe I shouldn't have mentioned the "in sh" bit. |
| 8 |
> If I re-submit stuff and just claim better readability and less code you'll |
| 9 |
> read it then? |
| 10 |
|
| 11 |
"better readability" is a pretty subjective claim ... i'd say that changing |
| 12 |
things from doing a case match against proper character classes to doing a |
| 13 |
printf against arbitrary character ranges (which btw are not locale safe, so |
| 14 |
i imagine you've introduced a regression there) is not "better". but i'm not |
| 15 |
the maintainer of said eclass. |
| 16 |
|
| 17 |
> > but I find interesting that |
| 18 |
> > you ripped Ciaran's copyright while leaving the "Prod ciaranm if you |
| 19 |
> > find something it can't handle" comment. |
| 20 |
> |
| 21 |
> I copied and pasted the comments for the most part. Sorry for leaving that |
| 22 |
> bit in. And I thought that the Gentoo Foundation had the copyright? |
| 23 |
|
| 24 |
it does. and if it doesnt, punt the file and rewrite it from scratch. |
| 25 |
-mike |
Archives