Gentoo Archives: gentoo-dev

From: Ulrich Mueller <ulm@g.o>
To: Mike Gilbert <floppym@g.o>
Cc: Gentoo Dev <gentoo-dev@l.g.o>
Subject: Re: [gentoo-dev] [PATCH v2] python-utils-r1.eclass: avoid nested ebegin calls
Date: Mon, 11 Jul 2022 17:57:35
Message-Id: uzghf7csd@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH v2] python-utils-r1.eclass: avoid nested ebegin calls by Mike Gilbert
1 >>>>> On Mon, 11 Jul 2022, Mike Gilbert wrote:
2
3 >> Maybe leave ebegin/eend in place then, which was invented precisely for
4 >> this use case? What's so bad about nesting it?
5
6 > It leads to odd looking output.
7
8 > https://gitweb.gentoo.org/proj/portage.git/commit/?id=eba088af8f335c0adb386461e6df1267e24800e7
9
10 IIUC it would look like this, with the patch applied:
11
12 * task 1
13 * Doing task 2 ... [ ok ]
14 * task 1 succeeded
15
16 That's not the most beautiful of outputs either.

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies