Gentoo Archives: gentoo-dev

From: Anna <cyber+gentoo@×××××.in>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH v2] python-utils-r1.eclass: avoid nested ebegin calls
Date: Mon, 11 Jul 2022 18:01:21
Message-Id: YsxlaF0iayyFGCYB@sysrq.in
In Reply to: Re: [gentoo-dev] [PATCH v2] python-utils-r1.eclass: avoid nested ebegin calls by Ulrich Mueller
1 On 2022-07-11 19:57, Ulrich Mueller wrote:
2 > >>>>> On Mon, 11 Jul 2022, Mike Gilbert wrote:
3 >
4 > >> Maybe leave ebegin/eend in place then, which was invented precisely for
5 > >> this use case? What's so bad about nesting it?
6 >
7 > > It leads to odd looking output.
8 >
9 > > https://gitweb.gentoo.org/proj/portage.git/commit/?id=eba088af8f335c0adb386461e6df1267e24800e7
10 >
11 > IIUC it would look like this, with the patch applied:
12 >
13 > * task 1
14 > * Doing task 2 ... [ ok ]
15 > * task 1 succeeded
16 >
17 > That's not the most beautiful of outputs either.
18
19 I think ebegin/eend output should be buffered so it can be nested
20 properly.

Replies