1 |
On Sunday 25 November 2012 11:47:42 Justin wrote: |
2 |
> # Copyright 1999-20012 Gentoo Foundation |
3 |
|
4 |
it is not yet 20012 |
5 |
|
6 |
also, this file too has whitespace damage (indenting with spaces) |
7 |
|
8 |
> [[ "${CUDA_VERBOSE}" == true ]] && NVCCFLAGS+=" -v" |
9 |
|
10 |
wouldn't this be better done in cuda_sanitize ? |
11 |
|
12 |
> local _gcc_bindir _ver _args="" _flag _ret |
13 |
|
14 |
they're local vars, so you don't need to use _ prefixes |
15 |
|
16 |
> if [[ ! $(type -P cuda-config) ]]; then |
17 |
|
18 |
it's more common to do something like: |
19 |
if cuda-config --help >/dev/null ; then |
20 |
|
21 |
or, you could even inline it with the existing code: |
22 |
|
23 |
if ! args=$(cuda-config -s); then |
24 |
... eerror/die ... |
25 |
else |
26 |
args=$(version_sort ${args}) |
27 |
... |
28 |
|
29 |
> if [[ ! -n ${_args} ]]; then |
30 |
|
31 |
use "-z", not "! -n" |
32 |
-mike |