| 1 |
On 28/11/12 00:11, Mike Frysinger wrote: |
| 2 |
> On Sunday 25 November 2012 11:47:42 Justin wrote: |
| 3 |
>> # Copyright 1999-20012 Gentoo Foundation |
| 4 |
> |
| 5 |
> it is not yet 20012 |
| 6 |
> |
| 7 |
> also, this file too has whitespace damage (indenting with spaces) |
| 8 |
> |
| 9 |
>> [[ "${CUDA_VERBOSE}" == true ]] && NVCCFLAGS+=" -v" |
| 10 |
> |
| 11 |
> wouldn't this be better done in cuda_sanitize ? |
| 12 |
> |
| 13 |
>> local _gcc_bindir _ver _args="" _flag _ret |
| 14 |
> |
| 15 |
> they're local vars, so you don't need to use _ prefixes |
| 16 |
> |
| 17 |
>> if [[ ! $(type -P cuda-config) ]]; then |
| 18 |
> |
| 19 |
> it's more common to do something like: |
| 20 |
> if cuda-config --help >/dev/null ; then |
| 21 |
> |
| 22 |
> or, you could even inline it with the existing code: |
| 23 |
> |
| 24 |
> if ! args=$(cuda-config -s); then |
| 25 |
> ... eerror/die ... |
| 26 |
> else |
| 27 |
> args=$(version_sort ${args}) |
| 28 |
> ... |
| 29 |
> |
| 30 |
>> if [[ ! -n ${_args} ]]; then |
| 31 |
> |
| 32 |
> use "-z", not "! -n" |
| 33 |
> -mike |
| 34 |
> |
| 35 |
|
| 36 |
Thanks for your comments, those are now integrated, |
| 37 |
|
| 38 |
Justin |
Archives