| 1 |
>>>>> On Sat, 15 Jun 2013, Mike Gilbert wrote: |
| 2 |
|
| 3 |
> The devmanual warns that calling die in a subshell does not work. |
| 4 |
|
| 5 |
> http://devmanual.gentoo.org/ebuild-writing/error-handling/index.html |
| 6 |
|
| 7 |
> This warning has been obsolete for some time; modern versions of |
| 8 |
> Portage handle die in a subshell just fine. |
| 9 |
|
| 10 |
> In fact, at least a couple of eclasses rely on this behavior. For |
| 11 |
> example, python-r1 uses subshells created by multiprocessing.eclass |
| 12 |
> to implement parallel "sub-phase" functions, any of which may call |
| 13 |
> die on failure. |
| 14 |
|
| 15 |
> Are there any objections to removing this warning from the |
| 16 |
> devmanual? |
| 17 |
|
| 18 |
PMS doesn't guarantee that die works correctly in a subshell: |
| 19 |
http://dev.gentoo.org/~ulm/pms/5/pms.html#x1-12800011.3.3 |
| 20 |
|
| 21 |
So the devmanual agrees with the spec, and the eclasses need to be |
| 22 |
fixed. |
| 23 |
|
| 24 |
Ulrich |
Archives