Re: [gentoo-dev] Re: eclass review for Gnome 2.32 and waf ebuilds

[Gilles Dartiguelongue]

Le samedi 04 décembre 2010 à 09:32 +0100, Michał Górny a écrit :
> On Fri, 3 Dec 2010 19:46:37 -0600
> Ryan Hill <dirtyepic@g.o> wrote:
>
> > On Fri, 03 Dec 2010 23:25:21 +0100
> > Gilles Dartiguelongue <eva@g.o> wrote:
> >
> > > Le vendredi 03 décembre 2010 à 21:54 +0100, Cyprien Nicolas a
> > > écrit :
> > > > I had a issue with waf, with that MAKEOPTS thing [1]
> > > > Maybe you could take the expression referred in comment #3 [1], as
> > > > Samuli did, or maybe someone else have a better proposition.
> > > >
> > > > 1  https://bugs.gentoo.org/show_bug.cgi?id=335119
> > >
> > > The sed expression in the proposed eclass is indeed too weak, I'll
> > > look after the one in this bug.
> >
> > This has come up enough times that we should write some common code.
>
> Well, if we're to commonize out some code, I'd suggest starting with
> scons_clean_makeopts() from scons-utils.eclass -- it's pretty *readable*
> and working variant of MAKEOPTS cleaning, in pure bash.
>

For the record, I chose using the same expression than the one in
perl-module eclass since the waf can only make use of -j and -k options
for the time being as far as my search goes.

Anyway, if any waf using maintainer wants to help maintaining the
eclass, feel free to add yourself to eclass headers, gnome is only there
because we need it for hamster-applet for now.

-- 
Gilles Dartiguelongue <eva@g.o>
Gentoo