Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: dirtyepic@g.o
Subject: Re: [gentoo-dev] Re: eclass review for Gnome 2.32 and waf ebuilds
Date: Sat, 04 Dec 2010 08:36:22
Message-Id: 20101204093258.6d57c577@pomiocik.lan
In Reply to: [gentoo-dev] Re: eclass review for Gnome 2.32 and waf ebuilds by Ryan Hill
1 On Fri, 3 Dec 2010 19:46:37 -0600
2 Ryan Hill <dirtyepic@g.o> wrote:
3
4 > On Fri, 03 Dec 2010 23:25:21 +0100
5 > Gilles Dartiguelongue <eva@g.o> wrote:
6 >
7 > > Le vendredi 03 décembre 2010 à 21:54 +0100, Cyprien Nicolas a
8 > > écrit :
9 > > > I had a issue with waf, with that MAKEOPTS thing [1]
10 > > > Maybe you could take the expression referred in comment #3 [1], as
11 > > > Samuli did, or maybe someone else have a better proposition.
12 > > >
13 > > > 1 https://bugs.gentoo.org/show_bug.cgi?id=335119
14 > >
15 > > The sed expression in the proposed eclass is indeed too weak, I'll
16 > > look after the one in this bug.
17 >
18 > This has come up enough times that we should write some common code.
19
20 Well, if we're to commonize out some code, I'd suggest starting with
21 scons_clean_makeopts() from scons-utils.eclass -- it's pretty *readable*
22 and working variant of MAKEOPTS cleaning, in pure bash.
23
24 --
25 Best regards,
26 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies