[gentoo-dev] Re: eclass review for Gnome 2.32 and waf ebuilds

[Ryan Hill]

On Fri, 03 Dec 2010 23:25:21 +0100
Gilles Dartiguelongue <eva@g.o> wrote:

> Le vendredi 03 décembre 2010 à 21:54 +0100, Cyprien Nicolas a écrit :
> > On Fri, Dec 3, 2010 at 21:25, Gilles Dartiguelongue <eva@g.o> wrote:
> > > Please also find in these patches a proposal of a waf-utils eclass in
> > > order to put waf related build management into an eclass. There is a
> > > couple of ebuilds already in tree all doing things on their own and I
> > > had a prototype laying around that I had to complete in order to have
> > > hamster-applet-2.32.
> >
> > I took a look at the src_compile function from the proposed
> > waf-utils.eclass, and the sed expression you use is not correct, if
> > your objective is to filter everything but the -j/--jobs part of the
> > MAKEOPTS variable.
> > My current setting is MAKEOPTS="--jobs=3 --load-average=3.5", and it
> > is left unchanged by the current sed expression.
> >
> > I had a issue with waf, with that MAKEOPTS thing [1]
> > Maybe you could take the expression referred in comment #3 [1], as
> > Samuli did, or maybe someone else have a better proposition.
> >
> > 1  https://bugs.gentoo.org/show_bug.cgi?id=335119
> >
>
> The sed expression in the proposed eclass is indeed too weak, I'll look
> after the one in this bug.

This has come up enough times that we should write some common code.

-- 
fonts, gcc-porting,                  it makes no sense how it makes no sense
toolchain, wxwidgets                           but i'll take it free anytime
@ gentoo.org                EFFD 380E 047A 4B51 D2BD C64F 8AA8 8346 F9A4 0662