| 1 |
On 02/02/16 23:36, Ryan Hill wrote: |
| 2 |
> On Mon, 1 Feb 2016 12:08:28 +0100 |
| 3 |
> Justin Lecher <jlec@g.o> wrote: |
| 4 |
> |
| 5 |
>> while tracking down the following error when running "egencache" |
| 6 |
>> |
| 7 |
>> GENTOO.GIT//eclass/wxwidgets.eclass: line 84: get_libdir: command not found |
| 8 |
>> GENTOO.GIT//eclass/wxwidgets.eclass: line 84: get_libdir: command not found |
| 9 |
>> GENTOO.GIT//eclass/wxwidgets.eclass: line 84: get_libdir: command not found |
| 10 |
>> GENTOO.GIT//eclass/wxwidgets.eclass: line 84: get_libdir: command not found |
| 11 |
>> GENTOO.GIT//eclass/wxwidgets.eclass: line 84: get_libdir: command not found |
| 12 |
>> GENTOO.GIT//eclass/wxwidgets.eclass: line 84: get_libdir: command not found |
| 13 |
>> GENTOO.GIT//eclass/wxwidgets.eclass: line 84: get_libdir: command not found |
| 14 |
>> GENTOO.GIT//eclass/wxwidgets.eclass: line 84: get_libdir: command not found |
| 15 |
>> GENTOO.GIT//eclass/wxwidgets.eclass: line 84: get_libdir: command not found |
| 16 |
>> |
| 17 |
>> I found that the global scope get_libdir() usage of the wxwidgets.eclass |
| 18 |
>> doens't work on EAPI=6. The following patches correct some minor things |
| 19 |
>> and block EAPI=6 for now until the eclass is ready. |
| 20 |
>> |
| 21 |
>> Justin Lecher (5): |
| 22 |
>> wxwidgets.eclass: Update Copyright year |
| 23 |
>> wxwidgets.eclass: Fix whitespaces |
| 24 |
>> wxwidgets.eclass: unset unneeded variables in global scope after usage |
| 25 |
>> wxwidgets.eclass: Only inherit eclass ones |
| 26 |
>> wxwidgets.eclass: Add EAPI support |
| 27 |
>> |
| 28 |
>> eclass/wxwidgets.eclass | 33 ++++++++++++++++++++++++--------- |
| 29 |
>> 1 file changed, 24 insertions(+), 9 deletions(-) |
| 30 |
>> |
| 31 |
> |
| 32 |
> 1. I don't think most of this is necessary but go ahead I guess. |
| 33 |
|
| 34 |
Most of them are trivial, but excluding EAPI=6 from supported EAPIs is |
| 35 |
essential. The usage of get_libdir needs to be moved to a phase |
| 36 |
function. Which should perhaps be coupled with an env variable which is |
| 37 |
checked in the later function to ensure the phase function has been run. |
| 38 |
|
| 39 |
> 2. When did we start posting every @&#$! eclass change to g-dev? File a bug |
| 40 |
> like a normal person. (There's already one open you could have used) |
| 41 |
|
| 42 |
I feel pretty "normal" when sending eclass changes to g-dev. Having code |
| 43 |
reviewed which influences a larger number of packages at once in the |
| 44 |
most public and open way is something we should strive for, isn't it? |
Archives