1 |
On Wed, 3 Feb 2016 10:21:40 +0100 |
2 |
"Justin Lecher (jlec)" <jlec@g.o> wrote: |
3 |
|
4 |
> On 02/02/16 23:36, Ryan Hill wrote: |
5 |
> > On Mon, 1 Feb 2016 12:08:28 +0100 |
6 |
> > Justin Lecher <jlec@g.o> wrote: |
7 |
> > |
8 |
> >> while tracking down the following error when running "egencache" |
9 |
> >> |
10 |
> >> GENTOO.GIT//eclass/wxwidgets.eclass: line 84: get_libdir: command not found |
11 |
> >> GENTOO.GIT//eclass/wxwidgets.eclass: line 84: get_libdir: command not found |
12 |
> >> GENTOO.GIT//eclass/wxwidgets.eclass: line 84: get_libdir: command not found |
13 |
> >> GENTOO.GIT//eclass/wxwidgets.eclass: line 84: get_libdir: command not found |
14 |
> >> GENTOO.GIT//eclass/wxwidgets.eclass: line 84: get_libdir: command not found |
15 |
> >> GENTOO.GIT//eclass/wxwidgets.eclass: line 84: get_libdir: command not found |
16 |
> >> GENTOO.GIT//eclass/wxwidgets.eclass: line 84: get_libdir: command not found |
17 |
> >> GENTOO.GIT//eclass/wxwidgets.eclass: line 84: get_libdir: command not found |
18 |
> >> GENTOO.GIT//eclass/wxwidgets.eclass: line 84: get_libdir: command not found |
19 |
> >> |
20 |
> >> I found that the global scope get_libdir() usage of the wxwidgets.eclass |
21 |
> >> doens't work on EAPI=6. The following patches correct some minor things |
22 |
> >> and block EAPI=6 for now until the eclass is ready. |
23 |
> >> |
24 |
> >> Justin Lecher (5): |
25 |
> >> wxwidgets.eclass: Update Copyright year |
26 |
> >> wxwidgets.eclass: Fix whitespaces |
27 |
> >> wxwidgets.eclass: unset unneeded variables in global scope after usage |
28 |
> >> wxwidgets.eclass: Only inherit eclass ones |
29 |
> >> wxwidgets.eclass: Add EAPI support |
30 |
> >> |
31 |
> >> eclass/wxwidgets.eclass | 33 ++++++++++++++++++++++++--------- |
32 |
> >> 1 file changed, 24 insertions(+), 9 deletions(-) |
33 |
> >> |
34 |
> > |
35 |
> > 1. I don't think most of this is necessary but go ahead I guess. |
36 |
> |
37 |
> Most of them are trivial, but excluding EAPI=6 from supported EAPIs is |
38 |
> essential. The usage of get_libdir needs to be moved to a phase |
39 |
> function. Which should perhaps be coupled with an env variable which is |
40 |
> checked in the later function to ensure the phase function has been run. |
41 |
|
42 |
Yeah, it just kind of screws us from getting sane defaults just by inheriting |
43 |
the eclass. I guess we'll have to find another way. |
44 |
|
45 |
> > 2. When did we start posting every @&#$! eclass change to g-dev? File a bug |
46 |
> > like a normal person. (There's already one open you could have used) |
47 |
> |
48 |
> I feel pretty "normal" when sending eclass changes to g-dev. Having code |
49 |
> reviewed which influences a larger number of packages at once in the |
50 |
> most public and open way is something we should strive for, isn't it? |
51 |
|
52 |
Yes, thanks and sorry for being crabby. |
53 |
|
54 |
-- |