Gentoo Archives: gentoo-dev

From: hasufell <hasufell@g.o>
To: gentoo-dev@l.g.o
Cc: games@g.o, mgorny@g.o, ryao@g.o
Subject: [gentoo-dev] New eclass: games-bin (review/comments)
Date: Sat, 23 Mar 2013 20:54:14
Message-Id: 514E1667.8030604@gentoo.org
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA1
3
4 After packaging the complete humble bundle last time I noticed a bit
5 of code duplication.
6 Nothing serious, but I still think there could be a small eclass
7 making things easier.
8
9 Especially the "remove_bundled_libs" function and the is useful IMO
10 and allows to easily remove those things.
11 The GAMES_PRESERVE_BUNDLED_LIBS array would allow to preserve libs,
12 e.g. stuff like "libbass" which is not present in the tree and even
13 GAMES_PRESERVE_BUNDLED_LIBS_amd64 (in case we have a 32bit only game
14 and there are no multilib versions for some of those libs).
15
16 It also works well with a "bundled-libs" useflag (see
17 games-bin_src_prepare), because it can happen that binary games break
18 while the tree is moving forward with library versions, or that system
19 libraries create weird blockers for the user or even cause runtime
20 breakage (which happened with the editor of games-rpg/grimrock wrt
21 #454934).
22
23 Most bin games use some functions from unpacker.eclass, so it is
24 inherited and used in games-bin_src_unpack by default.
25
26 I was also thinking about some check-reqs thing, but it's probably
27 better that is handled explicitly.
28
29
30 If you have suggestions or if you think that approach sucks, please
31 tell me.
32 -----BEGIN PGP SIGNATURE-----
33 Version: GnuPG v2.0.19 (GNU/Linux)
34 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
35
36 iQEcBAEBAgAGBQJRThZnAAoJEFpvPKfnPDWzl8EH/RARdOR2GKicEBGTxO2krO1A
37 AUcHcUlqjkgwaDmNcJ4HwbEhgVJG6vojNDihKJixlJShkD51tsVP/mhBzReH9zkE
38 RC7mBCek/uB5NrH5Vm2C1/dtBWAuxjJ2mN3a327a7U2tPcHkgYBGZtiAI7pSS8cl
39 UCfr315wBYPO95LZDUiuoQHw+ogzDP7RsrNhlJKHgwXJLE2oEUrtoKo3rkDwDZlU
40 ODVYT95sfZAHkyQDGhTusZB8Go+2+hhUHUua0yG30m4PXiW6j/4kCHYV59HRHYsj
41 6uEKpX4/h7xU0MZ1bOpqZHK2CoNlL7lPdxOMpQ/rVw8eyRNVuDpkyT1YkD/Rnj4=
42 =uaH2
43 -----END PGP SIGNATURE-----

Attachments

File name MIME type
games-bin.eclass text/plain

Replies

Subject Author
[gentoo-dev] Re: New eclass: games-bin (review/comments) Richard Yao <ryao@g.o>