Gentoo Archives: gentoo-dev

From: Donnie Berkholz <dberkholz@g.o>
To: gentoo-dev@l.g.o, je_fro@g.o
Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sci-biology/seaview: ChangeLog seaview-20060213.ebuild seaview-20041220.ebuild seaview-20070919.ebuild
Date: Sun, 21 Oct 2007 09:59:02
Message-Id: 20071021094534.GE3883@supernova
1 On 04:34 Sun 21 Oct , Jeffrey Gardner (je_fro) wrote:
2 > 1.3 sci-biology/seaview/seaview-20060213.ebuild
3 >
4 > file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/sci-biology/seaview/seaview-20060213.ebuild?rev=1.3&view=markup
5 > plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/sci-biology/seaview/seaview-20060213.ebuild?rev=1.3&content-type=text/plain
6 > diff : http://sources.gentoo.org/viewcvs.py/gentoo-x86/sci-biology/seaview/seaview-20060213.ebuild?r1=1.2&r2=1.3
7
8 > @@ -41,6 +41,6 @@
9 >
10 > src_install() {
11 > dobin seaview seaview_align.sh
12 > - insinto /usr/share/${PN}
13 > + insinto "/usr/share/${PN}"
14
15 You only need to do this if $PN could have spaces in it (which should
16 never be the case). Don't just blindly quote everything; by
17 understanding why it's done, you can understand in which cases it should
18 be done.
19
20 I hope that repoman did not suggest this.
21
22 Thanks,
23 Donnie
24 --
25 gentoo-dev@g.o mailing list

Replies