Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sci-biology/seaview: ChangeLog seaview-20060213.ebuild seaview-20041220.ebuild seaview-20070919.ebuild

[Alec Warner]

On 10/21/07, Donnie Berkholz <dberkholz@g.o> wrote:
> On 04:34 Sun 21 Oct     , Jeffrey Gardner (je_fro) wrote:
> > 1.3                  sci-biology/seaview/seaview-20060213.ebuild
> >
> > file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/sci-biology/seaview/seaview-20060213.ebuild?rev=1.3&view=markup
> > plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/sci-biology/seaview/seaview-20060213.ebuild?rev=1.3&content-type=text/plain
> > diff : http://sources.gentoo.org/viewcvs.py/gentoo-x86/sci-biology/seaview/seaview-20060213.ebuild?r1=1.2&r2=1.3
>
> > @@ -41,6 +41,6 @@
> >
> >  src_install() {
> >       dobin seaview seaview_align.sh
> > -     insinto /usr/share/${PN}
> > +     insinto "/usr/share/${PN}"
>
> You only need to do this if $PN could have spaces in it (which should
> never be the case). Don't just blindly quote everything; by
> understanding why it's done, you can understand in which cases it should
> be done.
>
> I hope that repoman did not suggest this.
>
> Thanks,
> Donnie

You told me on IRC 'people should quote all the time, as there is no
harm in overquoting' (aside from readability).  Yet here you tell him
to 'not blindly quote everything'.  So make up your mind ;)

> --
> gentoo-dev@g.o mailing list
>
>
-- 
gentoo-dev@g.o mailing list