Re: [gentoo-dev] [RFC] New eclass: mate

[Pacho Ramos]

Hi!

El lun, 11-04-2016 a las 22:04 -0400, NP-Hardass escribió:
> [...]
> # @FUNCTION: ematedocize
> # @DESCRIPTION: A wrapper around mate-doc-common
> ematedocize() {
>         ebegin "Running mate-doc-common --copy"
>                 mate-doc-common --copy || die
>         eend $?
> }
>

Have you think in reporting this to autotools.eclass maintainers to add
the needed logic to autotools.eclass as done for all the other stuff
like gnome-doc, intltool...

> # @FUNCTION: mate_src_prepare
> # @DESCRIPTION:
> # Call gnome2_src_prepare to handle environment setup and patching,
> then
> # call eautoreconf if necessary
> mate_src_prepare() {
>         debug-print-function ${FUNCNAME} "$@"
>
>         local force_autoreconf=${FORCE_AUTORECONF:-false}
>         [[ ${PV} == 9999 ]] && force_autoreconf=true
>
>         gen_chksum() {
>                 find '(' -name 'Makefile.am' \
>                         -o -name 'configure.ac' \
>                         -o -name 'configure.in' ')' \
>                         -exec cksum + | sort -k2
>         }
>
>         local chksum=$(gen_chksum)
>
>         gnome2_src_prepare
>
>         if ${force_autoreconf} || [[ ${chksum} != $(gen_chksum) ]];
> then
>                 eautoreconf
>                 ematedocize
>         fi
> }
>

I wonder if maybe this handling of "automatic eautoreconf" should be
moved to a more general eclass as there are some consumers that are
reimplementing this different times :/ 

In the past we could rely on autotools-utils.eclass for this, but now,
it looks like it needs to be redone in several other eclasses (for
example, xorg one)

But it's only a question/opinion, I am not blocking your change or
similar ;)