Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: Patrice Clement <monsieurp@g.o>
Cc: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH 02/13] python-utils-r1.eclass: Reorder implementations to semi-ascending order
Date: Wed, 09 Dec 2015 19:25:22
Message-Id: 20151209202445.02835f16.mgorny@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH 02/13] python-utils-r1.eclass: Reorder implementations to semi-ascending order by Patrice Clement
1 On Tue, 8 Dec 2015 09:19:57 +0100
2 Patrice Clement <monsieurp@g.o> wrote:
3
4 > Sunday 06 Dec 2015 20:03:21, Michał Górny wrote :
5 > > Reorder the Python implementations to ascending version order, with
6 > > CPython listed first and other implementations in descending preference.
7 > >
8 > > The previous ordering has been used for two reasons:
9 > >
10 > > 1. There were packages which supported Python 3.x or PyPy partially but
11 > > their documentation builds or test functions required CPython 2.x.
12 > > The specific ordering caused python_export_best (the predecessor of
13 > > python_setup) to use CPython 2.x for those tasks. This is now replaced
14 > > by explicit implementation restrictions in python_setup.
15 > >
16 > > 2. PyPy setup runs were usually slower than CPython, and CPython 3.x
17 > > runs were often slower due to 2to3 calls. Combined with parallel build
18 > > runs, this ordering caused slower builds to start earlier and sometimes
19 > > resulted in more efficient use of threads. However, nowadays we no
20 > > longer do parallel builds.
21 > >
22 > > Therefore, it seems reasonable to finally reorder the implementations
23 > > into a more intuitive order.
24 > > ---
25 > > eclass/python-utils-r1.eclass | 6 +++---
26 > > 1 file changed, 3 insertions(+), 3 deletions(-)
27 > >
28 > > diff --git a/eclass/python-utils-r1.eclass b/eclass/python-utils-r1.eclass
29 > > index 0bce6a9..3ea23a8 100644
30 > > --- a/eclass/python-utils-r1.eclass
31 > > +++ b/eclass/python-utils-r1.eclass
32 > > @@ -41,10 +41,10 @@ inherit toolchain-funcs
33 > > # @DESCRIPTION:
34 > > # All supported Python implementations, most preferred last.
35 > > declare -g -r _PYTHON_ALL_IMPLS=(
36 > > - jython2_5 jython2_7
37 > > - pypy pypy3
38 > > - python3_3 python3_4 python3_5
39 > > python2_7
40 > > + python3_3 python3_4 python3_5
41 > > + pypy pypy3
42 > > + jython2_5 jython2_7
43 > > )
44 > >
45 > > # @FUNCTION: _python_impl_supported
46 > > --
47 > > 2.6.3
48 > >
49 > >
50 >
51 > Michal,
52 >
53 > While at it, please delete jython2_5 from this list since jython versions < 2.7 are in
54 > the process of being purged from Portage.
55 >
56 > See https://bugs.gentoo.org/show_bug.cgi?id=552452
57
58 Will do, also from profiles.
59
60 --
61 Best regards,
62 Michał Górny
63 <http://dev.gentoo.org/~mgorny/>