Gentoo Archives: gentoo-dev

From: Patrice Clement <monsieurp@g.o>
To: gentoo-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: Re: [gentoo-dev] [PATCH 02/13] python-utils-r1.eclass: Reorder implementations to semi-ascending order
Date: Tue, 08 Dec 2015 08:20:20
Message-Id: 20151208081957.GD10221@ultrachro.me
In Reply to: [gentoo-dev] [PATCH 02/13] python-utils-r1.eclass: Reorder implementations to semi-ascending order by "Michał Górny"
1 Sunday 06 Dec 2015 20:03:21, Michał Górny wrote :
2 > Reorder the Python implementations to ascending version order, with
3 > CPython listed first and other implementations in descending preference.
4 >
5 > The previous ordering has been used for two reasons:
6 >
7 > 1. There were packages which supported Python 3.x or PyPy partially but
8 > their documentation builds or test functions required CPython 2.x.
9 > The specific ordering caused python_export_best (the predecessor of
10 > python_setup) to use CPython 2.x for those tasks. This is now replaced
11 > by explicit implementation restrictions in python_setup.
12 >
13 > 2. PyPy setup runs were usually slower than CPython, and CPython 3.x
14 > runs were often slower due to 2to3 calls. Combined with parallel build
15 > runs, this ordering caused slower builds to start earlier and sometimes
16 > resulted in more efficient use of threads. However, nowadays we no
17 > longer do parallel builds.
18 >
19 > Therefore, it seems reasonable to finally reorder the implementations
20 > into a more intuitive order.
21 > ---
22 > eclass/python-utils-r1.eclass | 6 +++---
23 > 1 file changed, 3 insertions(+), 3 deletions(-)
24 >
25 > diff --git a/eclass/python-utils-r1.eclass b/eclass/python-utils-r1.eclass
26 > index 0bce6a9..3ea23a8 100644
27 > --- a/eclass/python-utils-r1.eclass
28 > +++ b/eclass/python-utils-r1.eclass
29 > @@ -41,10 +41,10 @@ inherit toolchain-funcs
30 > # @DESCRIPTION:
31 > # All supported Python implementations, most preferred last.
32 > declare -g -r _PYTHON_ALL_IMPLS=(
33 > - jython2_5 jython2_7
34 > - pypy pypy3
35 > - python3_3 python3_4 python3_5
36 > python2_7
37 > + python3_3 python3_4 python3_5
38 > + pypy pypy3
39 > + jython2_5 jython2_7
40 > )
41 >
42 > # @FUNCTION: _python_impl_supported
43 > --
44 > 2.6.3
45 >
46 >
47
48 Michal,
49
50 While at it, please delete jython2_5 from this list since jython versions < 2.7 are in
51 the process of being purged from Portage.
52
53 See https://bugs.gentoo.org/show_bug.cgi?id=552452
54
55 Cheers,
56
57 --
58 Patrice Clement
59 Gentoo Linux developer
60 http://www.gentoo.org

Replies