| 1 |
I have no clue what cmake is or what you are trying to, so I just |
| 2 |
comment on a few other things I catched: |
| 3 |
|
| 4 |
> INHERITED="$INHERITED $ECLASS" |
| 5 |
|
| 6 |
you don't need that |
| 7 |
|
| 8 |
> cmake_use_option() { |
| 9 |
> local USEFLAG="$1"; shift |
| 10 |
> local OPTION="$1"; shift |
| 11 |
|
| 12 |
'local USEFLAG="$1" OPTION="$2" ; shift 2' reads better and is more |
| 13 |
efficient |
| 14 |
|
| 15 |
> if [ -z "${OPTION}" ]; then |
| 16 |
> OPTION="WITH_${USEFLAG}" |
| 17 |
> fi |
| 18 |
|
| 19 |
OPTION=${OPTION:-"WITH_${USEFLAG}"} |
| 20 |
|
| 21 |
> case $1 in |
| 22 |
> on|On|oN|ON) |
| 23 |
|
| 24 |
'[oO][nN]') does the same, but i doubt anything beside on|ON will ever |
| 25 |
be used. |
| 26 |
|
| 27 |
> off|ofF|oFf|oFF|Off|OfF|OFf|OFF) |
| 28 |
|
| 29 |
same here: |
| 30 |
[oO][fF][fF]) or simply off|OFF) |
| 31 |
wE'rE nOt ThAt FrEaKy YoU kNoW ;) |
| 32 |
|
| 33 |
> cmake_configure() { |
| 34 |
[...] |
| 35 |
> vecho cmake ${S} -DCMAKE_INSTALL_PREFIX=/usr $(cmake_use_option debug CMAKE_BUILD_TYPE debugfull) $* |
| 36 |
|
| 37 |
You can't use vecho yet. It's been introduced not long ago, stable |
| 38 |
portage versions will just tell you that there is no `vecho'. |
| 39 |
|
| 40 |
> cmake_compile() { |
| 41 |
> cmake_install() { |
| 42 |
|
| 43 |
aren't these meant to be cmake-src_compile/cmake-src_install? |
| 44 |
|
| 45 |
-- |
| 46 |
Kind Regards, |
| 47 |
|
| 48 |
Simon Stelling |
| 49 |
Gentoo/AMD64 Developer |
| 50 |
-- |
| 51 |
gentoo-dev@g.o mailing list |
Archives