| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA256 |
| 3 |
|
| 4 |
On 27/05/14 04:05 AM, Tom Wijsman wrote: |
| 5 |
> On Tue, 27 May 2014 09:02:37 +0200 ""Paweł Hajdan, Jr."" |
| 6 |
> <phajdan.jr@g.o> wrote: |
| 7 |
> |
| 8 |
>> I'm seriously considering just removing src_test to make the |
| 9 |
>> package more maintainable (less code, less bugs filed, can focus |
| 10 |
>> on things that *do* impact our users). |
| 11 |
>> |
| 12 |
>> If you decide to comment in favor of keeping src_test, please |
| 13 |
>> consider volunteering to help us with the bugs. |
| 14 |
>> |
| 15 |
>> Feel free to suggest solutions that fall somewhere in between - |
| 16 |
>> e.g. having src_test but not excluding any tests there and using |
| 17 |
>> RESTRICT=test, so that someone who really wants to run the tests |
| 18 |
>> FYI can do so. |
| 19 |
> |
| 20 |
> From a "test it for proper maintenance" point of view this makes |
| 21 |
> some sense; however, from a "test it for proper usability" point of |
| 22 |
> view this might become a bit questionable. Some users like to run |
| 23 |
> these tests in order to know their browser will work on their |
| 24 |
> system; perhaps even going further than that, it helps more users |
| 25 |
> report bugs upstream. |
| 26 |
> |
| 27 |
> You could ask the users to file the tests related bugs upstream. |
| 28 |
> |
| 29 |
|
| 30 |
I don't know how much chromium is built and tested on lesser-used |
| 31 |
arches (ie: arm, hppa, ia64, etc), but if there are dev's that try and |
| 32 |
maintain these keywords that aren't in the team, it might be a good |
| 33 |
idea to leave src_test in place, for them. However, you could always |
| 34 |
wrap the actual contents of src_test with an "if [[ -n |
| 35 |
${I_KNOW_WHAT_IM_DOING} ]] " or similar to keep tests from running |
| 36 |
when the general userbase is trying to emerge it and happens to have |
| 37 |
FEATURES="test" globally enabled.. |
| 38 |
|
| 39 |
An ewarn telling users that if they really do want to run these tests, |
| 40 |
they can set the variable in make.conf or package.env or similar, and |
| 41 |
also specifying that the tests are skipped due to only being useful |
| 42 |
for upstream developers, may suffice... thoughts? |
| 43 |
|
| 44 |
|
| 45 |
-----BEGIN PGP SIGNATURE----- |
| 46 |
Version: GnuPG v2.0.22 (GNU/Linux) |
| 47 |
|
| 48 |
iF4EAREIAAYFAlOEnKkACgkQ2ugaI38ACPCBswD8CAx2cK2UH+/IzysGPiQjOEzF |
| 49 |
n8Sxv3ZbtKh9+aBFv9IBAIMhfmgABYnUJlGUg/+mPHOY1d9XDRfM9WQskiJBc2Xk |
| 50 |
=nWr/ |
| 51 |
-----END PGP SIGNATURE----- |
Archives