[gentoo-dev] Re: [PATCH] To enable ssp default in Gcc the toolchain.eclass need some changes.

[Ryan Hill]

On Fri, 10 Jan 2014 01:35:09 -0500
"Rick \"Zero_Chaos\" Farina" <zerochaos@g.o> wrote:

> More to the point, "this specific use flag" appears to have no purpose
> what-so-ever.  If a user can do exactly the same with
> CFLAGS=-fno-stack-protector in make.conf, and it would be INSANE for a
> package to dep on gcc[nossp] then this is has got to be one of the most
> useless use flags in gentoo.

Having slept on it I'm starting to agree.  My first argument was that on
hardened ssp is -fstack-protector-all, which is much more expensive, and it
adds -fstack-check and -z,now to the linker by default as well.  The pie half
adds -fPIE but also a crtbeginP section for linking static libs with -pie.  So
there are situations where you want to disable one or both, if only for
testing.  But what I forgot is that hardened installs multiple gcc-config
profiles to switch these out on the fly.  So there goes that idea.

It might be useful to have these flags so we can mask them on archs that don't
support ssp/pie.  But that's always been true and it looks like sh is the only
place we've bothered for some reason.

> Not saying I would block this patch, not saying it has to be this
> second, but I see this use flag as a small example of things in
> toolchain which could probably be cleaned up if fresh eyes were to see
> things.

Yes, and believe it or not I appreciate the input.  I know I'm stubborn as hell
but eventually common sense gets through.


-- 
Ryan Hill                        psn: dirtyepic_sk
   gcc-porting/toolchain/wxwidgets @ gentoo.org

47C3 6D62 4864 0E49 8E9E  7F92 ED38 BD49 957A 8463