Gentoo Archives: gentoo-dev

From: "Rick \\\"Zero_Chaos\\\" Farina" <zerochaos@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Re: [PATCH] To enable ssp default in Gcc the toolchain.eclass need some changes.
Date: Fri, 10 Jan 2014 06:35:00
Message-Id: 52CF949D.9010501@gentoo.org
In Reply to: [gentoo-dev] Re: [PATCH] To enable ssp default in Gcc the toolchain.eclass need some changes. by Ryan Hill
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA1
3
4 On 01/09/2014 07:12 PM, Ryan Hill wrote:
5 > On Thu, 9 Jan 2014 17:41:08 -0600
6 > William Hubbs <williamh@g.o> wrote:
7 >
8 >> On Fri, Jan 10, 2014 at 12:30:04AM +0100, Andreas K. Huettel wrote:
9 >>> Am Freitag, 10. Januar 2014, 00:26:03 schrieb Ryan Hill:
10 >>>>
11 >>>>> Please avoid "noblah" use flags.
12 >>>>>
13 >>>>> http://devmanual.gentoo.org/general-concepts/use-flags/
14 >>>>>
15 >>>>> ssp flag that defaults to on is fine.
16 >>>>
17 >>>> This flag already exists and has always worked this way.
18 >>>
19 >>> "already exists and has always worked this way" is not really a good
20 >>> argument. The rest of the tree sticks to guidelines, so why not here?
21 >>
22 >> Agreed again. Saying that something has always worked a certain way in
23 >> the past is not justification for keeping it working that way,
24 >> especially when there are preferred ways of doing the same thing that
25 >> are different.
26 >
27 > Sure, I'm just pointing out that nothing is changing here. It sounded like
28 > people were objecting to the addition of a new no* flag. I agree we should
29 > change them once we can but that shouldn't block this patch.
30
31 To be clear, I don't believe the QA team has any desire to block forward
32 progress including this patch.
33 I think everyone is chomping at the bit here to see some improvement on
34 toolchain getting more up to date, and more with the QA policies that
35 have been in place for years. I realize eapi 2 wasn't "that long ago"
36 for some of you, but seriously, it was that long ago.
37
38 More to the point, "this specific use flag" appears to have no purpose
39 what-so-ever. If a user can do exactly the same with
40 CFLAGS=-fno-stack-protector in make.conf, and it would be INSANE for a
41 package to dep on gcc[nossp] then this is has got to be one of the most
42 useless use flags in gentoo.
43
44 Not saying I would block this patch, not saying it has to be this
45 second, but I see this use flag as a small example of things in
46 toolchain which could probably be cleaned up if fresh eyes were to see
47 things.
48
49 - -Zero
50 >
51 >
52 >>>> We don't have USE defaults yet.
53 >>>
54 >>> Now if you had said "we can't use USE defaults yet since current ebuilds
55 >>> are still at EAPI=0"... that would have been slightly more informative. :)
56 >>>
57 >>> (Yes I've seen that there is work going on, and I think that's good. Being
58 >>> careful when modernizing makes sense here of course.)
59 >>
60 >> Right, I thought someone had updated toolchain.eclass to use a modern
61 >> eapi, but I hadn't seen any more on that in some time. What's the
62 >> latest?
63 >
64 > I did, but I can't start using new features until I bring all the ebuilds up to
65 > a minimum EAPI. I'm going to start that this weekend.
66 >
67 >
68 >
69
70 -----BEGIN PGP SIGNATURE-----
71 Version: GnuPG v2.0.22 (GNU/Linux)
72 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
73
74 iQIcBAEBAgAGBQJSz5SdAAoJEKXdFCfdEflKq6wQAILiZN+BVZh+8XrEBsd4a0om
75 aOk6Inj4zWMK2y5LvI+T29u1xMvko18lu4Vny4dv13w6OMXsE+nip+1nOhxNyJJG
76 lCwiVWC603pzYw5am/q/XGg/GncjQFkx3FUSRlM8rJrRCQOyLinronojTtIG0GeV
77 e4k4eHih+wx73agAHXdvLrXP0Ps11yYxY5+U1Rkjf9p4LwMCtJTAwidm0458YZSp
78 7+ZYJHiBQvLOpG+evcTx8r+7WqfROjIPpFsCXfuPvZiTbGalXK0hEp1rWZ3aDSsw
79 wZyjo7cuucTGGDn58QRUIH5KLDZtPC0SVUZl9TVbT+rVbv/ugrboIH2rA33UxYr0
80 yUFj96gZCgVOHgmxsuOUhiR4R2yIDoFOFg7GEU1TL7ydnqPbxZ9FiYuwOTO5/6oN
81 hqofWQgC9DgjVDB8V/9m4SON7xZbCsmUhlXM1BCCaDx4HlfsgyHn2QQThRwYM4Oq
82 HHIA8dCBZytyhlZZ/E8qFlebkbBc7CmsU52htp/iI/eSVMBs7856ljzVbToyY95Q
83 ClGHIF7zRRWW2tGNo9EurKt+U+esuJS6h2buRwRzWVW8nJYy3z11BnkzGp9vwTAc
84 1GO3kfruHDTtuvB7esSJAfCdz5WDQ/i7rdj5DkaSISrRL0sIQsgeGPDP2Z7+V4cq
85 0ItbZIIb/50u8JHNiucS
86 =lrYq
87 -----END PGP SIGNATURE-----

Replies