Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in www-apps/dspam-web: dspam-web-3.8.0.ebuild ChangeLog

[Mike Frysinger]

On Monday 24 September 2007, Donnie Berkholz wrote:
> On 20:40 Mon 24 Sep     , Alin Nastac (mrness) wrote:
> >   Modified:             dspam-web-3.8.0.ebuild ChangeLog
> >
> > +	local use_errors=0
> > +	if built_with_use "mail-filter/dspam" user-homedirs; then
> > +		echo
> > +		eerror "The DSPAM web interface requires that mail-filter/dspam be
> > installed without user-homedirs USE flag." eerror "Please disable this
> > flag and re-emerge dspam."
> > -		die "Incompatible mail-filter/dspam installation"
> > +		use_errors=$[${use_errors} + 1]
> > +	fi
> > +	if ! built_with_use "dev-perl/GD" png; then
> > +		echo
> > +		eerror "The DSPAM web interface requires that dev-perl/GD be installed
> > with png USE flag." +		eerror "Please enable this flag and re-emerge GD."
> > +		use_errors=$[${use_errors} + 1]
> >  	fi
> > +	[ ${use_errors} -gt 0 ] && die "Dependency installed with incompatible
> > USE flags"
>
> You could use C-style syntax here:
>
> (( use_errors++ ))
>
> I find it a bit more readable.

i like to get anal and use ((++use_errors))

then again, it may also be more readable like so:
use_errors=false
if ... ; then
	...
	use_errors=true
fi
if ... ; then
	...
	use_errors=true
fi
${use_errors} && die "..."
-mike