| 1 |
On Monday 16 February 2015 06:13:10 Mike Frysinger wrote: |
| 2 |
> On Mon, Feb 16, 2015 at 1:16 AM, Alec Warner <antarus@g.o> wrote: |
| 3 |
> > On Sun, Feb 15, 2015 at 8:05 PM, Mike Frysinger <vapier@g.o> wrote: |
| 4 |
> >> On Wed, Dec 31, 2014 at 12:21 AM, Patrick Lauer (patrick) |
| 5 |
> >> |
| 6 |
> >> <patrick@g.o> wrote: |
| 7 |
> >> > patrick 14/12/31 05:21:11 |
| 8 |
> >> > |
| 9 |
> >> > Removed: ChangeLog Manifest libusbhp-1.0.2.ebuild |
| 10 |
> >> > |
| 11 |
> >> > metadata.xml |
| 12 |
> >> > |
| 13 |
> >> > Log: |
| 14 |
> >> > QA: Remove package with invalid copyright |
| 15 |
> >> |
| 16 |
> >> you do not go reverting code without actually talking to people. if |
| 17 |
> >> you feel like a revert is necessary, then file a bug. putting a "QA" |
| 18 |
> >> tag at the start of the commit message doesn't give you a pass. |
| 19 |
> > |
| 20 |
> > Normally I'd side with you on this...but I'm fairly sure repoman doesn't |
| 21 |
> > let you commit packages to the tree missing these headers. This leads me |
| 22 |
> > to believe you didn't use repoman, or ignored it? |
| 23 |
> |
| 24 |
> feel free to grab the code i originally committed and run `repoman |
| 25 |
> full` yourself. no fatal errors. in fact you can see the generated |
| 26 |
> tags in my commit message. |
| 27 |
|
| 28 |
Well, AutoRepoman triggered on it. |
| 29 |
|
| 30 |
Testing for fun on a random ebuild: |
| 31 |
|
| 32 |
RepoMan scours the neighborhood... |
| 33 |
ebuild.badheader 1 |
| 34 |
dev-db/hyperdex/hyperdex-1.6.0-r1.ebuild: Invalid Gentoo Copyright on line: |
| 35 |
1 |
| 36 |
|
| 37 |
|
| 38 |
Which again leads me to the question: |
| 39 |
|
| 40 |
Why are these checks not properly fatal? |
| 41 |
|
| 42 |
(And I really do not like having to repeat myself ...) |
| 43 |
|
| 44 |
> |
| 45 |
> even then, deleting an ebuild purely due to different copyright is |
| 46 |
> complete bs. anyone who understands copyright knows the situation in |
| 47 |
> Gentoo is completely unenforceable. we have no CLA. this was |
| 48 |
> patrick/QA wasting people's time to check a meaningless box. |
| 49 |
> -mike |
| 50 |
|
| 51 |
As others have pointed out, policy is policy. Don't shoot the massager. |
| 52 |
|
| 53 |
Since I can't just fix the copyright (that would be more wrong) I opted for the |
| 54 |
easy way out - remove offending bits. |
| 55 |
|
| 56 |
|
| 57 |
Have fun, |
| 58 |
|
| 59 |
Patrick |
Archives