Gentoo Archives: gentoo-dev

From: "Tomáš Chvátal" <scarabeus@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] git-2.eclass final review
Date: Tue, 22 Mar 2011 22:40:59
Message-Id: 4D8924CD.8000404@gentoo.org
In Reply to: Re: [gentoo-dev] git-2.eclass final review by Mike Frysinger
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA1
3
4 Dne 22.3.2011 22:26, Mike Frysinger napsal(a):
5 >> # @BLURB: This eclass provides functions for fetch and unpack git repositories
6 >
7 > fetching/unpacking
8
9 Yarp fixed.
10 >
11 >> eval X="\$${PN//[-+]/_}_LIVE_REPO"
12 >> if [[ ${X} = "" ]]; then
13 >> : ${EGIT_REPO_URI:=}
14 >> else
15 >> EGIT_REPO_URI="${X}"
16 >> fi
17 >
18 > X needs to be marked local, and could be condensed:
19 > EGIT_REPO_URI=${X:-${EGIT_REPO_URI}}
20 >
21 Hopefully implemented.
22
23 > the PN_LIVE_REPO override documentation is missing
24 It is on purpose.
25 It is semisecret hack that allows you to localy bend live ebuilds
26 without any need for rewriting it or adding some variables (eg. reason
27 why we have just one live mesa ebuild and no branches based ones).
28
29 If you think this thing should be official we can document it, but i
30 really really think that people by default should not be aware of this.
31 >
32 > same feedback for all the vars after this too
33 >
34 >> git-2_fetch $@
35 >
36 > missing quotes
37 Fixed
38
39 Handy link to gitdiff over gitweb: http://tinyurl.com/6focxa9
40
41 Thanks
42
43 Tom
44
45
46
47 -----BEGIN PGP SIGNATURE-----
48 Version: GnuPG v2.0.17 (GNU/Linux)
49 Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
50
51 iEYEARECAAYFAk2JJM0ACgkQHB6c3gNBRYd7fQCffqyoRouirScE2B8npuhEjLEF
52 Hx4AnRuyyIs5OG3WnRfKgM9itydIpJdE
53 =Nlbz
54 -----END PGP SIGNATURE-----

Replies

Subject Author
Re: [gentoo-dev] git-2.eclass final review Mike Frysinger <vapier@g.o>