Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: [gentoo-dev] [PATCH 3/8] linux-info.eclass: linux-info_get_any_version, die on failure
Date: Thu, 08 Mar 2018 17:07:18
Message-Id: 20180308170548.5782-4-mgorny@gentoo.org
In Reply to: [gentoo-dev] [PATCH 0/8] linux-info.eclass: cleanup & better non-Linux support by "Michał Górny"
1 Make linux-info_get_any_version die if it can't determine any version
2 of the Linux kernel. This indicates a problem with the eclass code
3 (as it should not happen on Linux) and the missing KV_* variables
4 are going to cause random misbehavior and failures.
5 ---
6 eclass/linux-info.eclass | 4 +++-
7 1 file changed, 3 insertions(+), 1 deletion(-)
8
9 diff --git a/eclass/linux-info.eclass b/eclass/linux-info.eclass
10 index df6227220b79..37a60b430646 100644
11 --- a/eclass/linux-info.eclass
12 +++ b/eclass/linux-info.eclass
13 @@ -630,7 +630,9 @@ get_running_version() {
14 linux-info_get_any_version() {
15 if ! get_version; then
16 ewarn "Unable to calculate Linux Kernel version for build, attempting to use running version"
17 - get_running_version
18 + if ! get_running_version; then
19 + die "Unable to determine any Linux Kernel version, please report a bug"
20 + fi
21 fi
22 }
23
24 --
25 2.16.2

Replies