| 1 |
On Thu, Mar 08, 2018 at 06:05:43PM +0100, Michał Górny wrote: |
| 2 |
> Make linux-info_get_any_version die if it can't determine any version |
| 3 |
> of the Linux kernel. This indicates a problem with the eclass code |
| 4 |
> (as it should not happen on Linux) and the missing KV_* variables |
| 5 |
> are going to cause random misbehavior and failures. |
| 6 |
This change worries me a bit. get_running_version calls get_version in |
| 7 |
some cases, and there are corner cases there which could trip this up. |
| 8 |
|
| 9 |
linux-info_get_any_version -> get_running_version -> get_version |
| 10 |
with get_version returning non-zero. |
| 11 |
|
| 12 |
get_version has ALREADY returned non-zero once in that path, and we're |
| 13 |
potentially tweaking KERNEL_DIR/KBUILD_OUTPUT before calling it again. |
| 14 |
|
| 15 |
Most of the breakage cases IIRC are where |
| 16 |
/lib/modules/${KV_FULL}/*/Makefile still exist, but point to kernel |
| 17 |
sources in weird places that are broken. |
| 18 |
|
| 19 |
-- |
| 20 |
Robin Hugh Johnson |
| 21 |
Gentoo Linux: Dev, Infra Lead, Foundation Treasurer |
| 22 |
E-Mail : robbat2@g.o |
| 23 |
GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85 |
| 24 |
GnuPG FP : 7D0B3CEB E9B85B1F 825BCECF EE05E6F6 A48F6136 |
Archives