Gentoo Archives: gentoo-dev

From: Anna <cyber+gentoo@×××××.in>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] distutils-r1.eclass: support nonfatal in test
Date: Fri, 06 Jan 2023 00:03:11
Message-Id: Y7dlNxz8HnnKKBOK@sysrq.in
In Reply to: [gentoo-dev] [PATCH] distutils-r1.eclass: support nonfatal in test by alexey+gentoo@asokolov.org
1 On 2023-01-05 23:55, alexey+gentoo@××××××××.org wrote:
2 > From: Alexey Sokolov <alexey+gentoo@××××××××.org>
3 >
4 > Signed-off-by: Alexey Sokolov <alexey+gentoo@××××××××.org>
5 > ---
6 > eclass/distutils-r1.eclass | 4 ++--
7 > 1 file changed, 2 insertions(+), 2 deletions(-)
8 >
9 > diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
10 > index 371d52bcb7e..8896768d3ce 100644
11 > --- a/eclass/distutils-r1.eclass
12 > +++ b/eclass/distutils-r1.eclass
13 > @@ -1,4 +1,4 @@
14 > -# Copyright 1999-2022 Gentoo Authors
15 > +# Copyright 1999-2023 Gentoo Authors
16 > # Distributed under the terms of the GNU General Public License v2
17 >
18 > # @ECLASS: distutils-r1.eclass
19 > @@ -1559,7 +1559,7 @@ distutils-r1_python_test() {
20 > esac
21 >
22 > if [[ ${?} -ne 0 ]]; then
23 > - die "Tests failed with ${EPYTHON}"
24 > + die -n "Tests failed with ${EPYTHON}"
25
26 I don't think "nonfatal" should be used with tests. Any valid use cases
27 for that?
28
29 > fi
30 > }
31 >
32 > --
33 > 2.38.2
34 >
35 >

Replies

Subject Author
Re: [gentoo-dev] [PATCH] distutils-r1.eclass: support nonfatal in test Alexey Sokolov <alexey+gentoo@××××××××.org>