Gentoo Archives: gentoo-dev

From: Alexey Sokolov <alexey+gentoo@××××××××.org>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] distutils-r1.eclass: support nonfatal in test
Date: Fri, 06 Jan 2023 00:05:58
Message-Id: b963af6f-1fa4-16b7-bca5-a41d5c3db848@asokolov.org
In Reply to: Re: [gentoo-dev] [PATCH] distutils-r1.eclass: support nonfatal in test by Anna
1 06.01.2023 00:03, Anna пишет:
2 > On 2023-01-05 23:55, alexey+gentoo@××××××××.org wrote:
3 >> From: Alexey Sokolov <alexey+gentoo@××××××××.org>
4 >>
5 >> if [[ ${?} -ne 0 ]]; then
6 >> - die "Tests failed with ${EPYTHON}"
7 >> + die -n "Tests failed with ${EPYTHON}"
8 >
9 > I don't think "nonfatal" should be used with tests. Any valid use cases
10 > for that?
11
12 src_test() {
13 virtx distutils-r1_src_test
14 }
15
16 If the test fails with "die", Xvfb keeps running forever; but it's
17 cleaned up correctly with die -n
18
19 --
20 Best regards,
21 Alexey "DarthGandalf" Sokolov

Replies