| 1 |
> On 6 Jan 2023, at 00:05, Alexey Sokolov <alexey+gentoo@××××××××.org> wrote: |
| 2 |
> |
| 3 |
> 06.01.2023 00:03, Anna пишет: |
| 4 |
>> On 2023-01-05 23:55, alexey+gentoo@××××××××.org wrote: |
| 5 |
>>> From: Alexey Sokolov <alexey+gentoo@××××××××.org> |
| 6 |
>>> |
| 7 |
>>> if [[ ${?} -ne 0 ]]; then |
| 8 |
>>> - die "Tests failed with ${EPYTHON}" |
| 9 |
>>> + die -n "Tests failed with ${EPYTHON}" |
| 10 |
>> I don't think "nonfatal" should be used with tests. Any valid use cases |
| 11 |
>> for that? |
| 12 |
> |
| 13 |
> src_test() { |
| 14 |
> virtx distutils-r1_src_test |
| 15 |
> } |
| 16 |
> |
| 17 |
> If the test fails with "die", Xvfb keeps running forever; but it's cleaned up correctly with die -n |
| 18 |
> |
| 19 |
|
| 20 |
Rationale should be mentioned in the commit message. Could you put it in? |
Archives