| 1 |
Alec Warner wrote: |
| 2 |
> On 10/15/07, Doug Goldstein <cardoe@g.o> wrote: |
| 3 |
> |
| 4 |
>> Jonathan Adamczewski wrote: |
| 5 |
>> |
| 6 |
>>> Doug Goldstein wrote: |
| 7 |
>>> |
| 8 |
>>> |
| 9 |
>>>> That's what this commits review list feels like. |
| 10 |
>>>> |
| 11 |
>>>> |
| 12 |
>>>> |
| 13 |
>>> Nearly every suggestion (from Donnie and others) has been over some |
| 14 |
>>> issue that relates directly to either correctness or maintainability. |
| 15 |
>>> It doesn't matter if you can "rattle off capabilities to a millimeter" - |
| 16 |
>>> if they're not documented somewhere (like, say, in the comments of the |
| 17 |
>>> ebuild) then the maintainer that comes after you gets to go and break it |
| 18 |
>>> all over again. |
| 19 |
>>> |
| 20 |
>>> |
| 21 |
>>> jonathan. |
| 22 |
>>> |
| 23 |
>>> |
| 24 |
>> Correctness? Fine. Go ahead. Stick $(use_enable xvmc) into the ebuild. |
| 25 |
>> Do it. I dare you. Then try to compile. |
| 26 |
>> |
| 27 |
>> Guess what? When it blows up... that's called INcorrect. The opposite of |
| 28 |
>> the right thing. |
| 29 |
>> |
| 30 |
>> The maintainer who comes after me would be someone with a experience |
| 31 |
>> with the package. Some bumkin isn't going to come to maintain package |
| 32 |
>> XYZ unless they know or use the package, and guess what? That means |
| 33 |
>> experience. |
| 34 |
>> |
| 35 |
> |
| 36 |
> I think this assumption is false. People maintain packages they don't |
| 37 |
> know the intricate details of all the time. You are of course, free |
| 38 |
> to ignore any and all suggestions offered; but you are not allowed to |
| 39 |
> silence them. |
| 40 |
> |
| 41 |
> -Alec |
| 42 |
> |
| 43 |
I must have not received my silence/moderate remote control for the |
| 44 |
Gentoo mailing lists. Since I haven't received it, I clearly can't |
| 45 |
silence anyone on the mailing lists. |
| 46 |
|
| 47 |
I still stand by my original feeling that we'd better the community NOT |
| 48 |
only the developers doing the commits by updating the devmanual, which |
| 49 |
is accessible to all developers and all users in the Gentoo community. |
| 50 |
In addition to updating and cleaning up repoman checks, which is a tool |
| 51 |
that everyone in the community can use. This is versus individual |
| 52 |
examples in random ebuilds in random e-mails that all have almost an |
| 53 |
identical subject on the mailing list. |
| 54 |
|
| 55 |
The commits review is flawed because if we're not documenting this stuff |
| 56 |
in one central place, then when new developers join. The same lessons |
| 57 |
have to be learned over and over again. |
| 58 |
|
| 59 |
Then again, this depends on the QA guys actually doing something about |
| 60 |
the outstanding bugs. |
| 61 |
-- |
| 62 |
gentoo-dev@g.o mailing list |
Archives