Gentoo Archives: gentoo-dev

From: Dirkjan Ochtman <djc@g.o>
To: Gentoo Development <gentoo-dev@l.g.o>
Subject: Re: [gentoo-dev] Signed-off-by verification incoming
Date: Sat, 29 Sep 2018 13:25:45
Message-Id: CAKmKYaDdYJfC26QSPE4-LOgpnb2JPG4d+w1YgFp+GotEoT4V2w@mail.gmail.com
In Reply to: Re: [gentoo-dev] Signed-off-by verification incoming by Jeroen Roovers
1 On Sat, Sep 29, 2018 at 3:14 PM Jeroen Roovers <jer@g.o> wrote:
2
3 > 0a) Explain to me how to fix my commits that I now can't push, or
4 > 0b) disable that hook immediately.
5 >
6
7 Try git rebase -i and use "r" for "reword" on every commit.
8
9
10 > 1) Update repoman to enforce it _before_ the commit is executed.
11 >
12
13 Some kind of repoman support would make this much easier to handle. As it
14 is, doing this by hand for the trivial case (only my own changes) is a
15 PITA. repoman could grow some kind of --sign-off option that appends this
16 to the commit message presumably?
17
18 I think repoman checks happen on the tree, not on the commit, so I'm not
19 sure how you think enforcing it before the commit makes sense (the line is
20 effectively part of the commit).
21
22
23 > 2) Wait for the repoman update to trickle down to all developers.
24 > 3) Announce it ahead of time.
25 >
26
27 Some more lead time would be appreciated, yes.
28
29 Regards,
30
31 Dirkjan

Replies