1 |
On Sat, 29 Sep 2018 10:19:10 +0200 |
2 |
Michał Górny <mgorny@g.o> wrote: |
3 |
|
4 |
> Hi, everyone. |
5 |
> |
6 |
> Just FYI, I'm going to enable the git hook to verify Signed-off-by |
7 |
> tags on gentoo.git (most likely all repos later on). I've tested it |
8 |
> against all the test cases I could think of but if you have any |
9 |
> trouble pushing, please ping me or others in #-infra. |
10 |
> |
11 |
> Please note that for the hook to work: |
12 |
> |
13 |
> 1. Every commit must contain 'Signed-off-by' of the committer. |
14 |
> |
15 |
> 2. You must use your @gentoo.org address in committer (this was |
16 |
> already enforced) and in Signed-off-by. |
17 |
> |
18 |
> 3. You must use your real name *as stated in LDAP* in Signed-off-by |
19 |
> (committer can be anything). Both regular (cn) and ASCII (gecos) |
20 |
> version is accepted, and the match should be case-insensitive (at |
21 |
> least as far as case-insensitive works in bash). |
22 |
> |
23 |
> If you need to change your real name to match your preferred spelling |
24 |
> (e.g. 'Matt' to 'Matthew'), please ping us as well. |
25 |
> |
26 |
> As a side note, I'd like to repeat that while this is not enforced, |
27 |
> if you merge a copyrightable (i.e. non-trivial) external contribution, |
28 |
> please get Signed-off-by from its author and append yours below it. |
29 |
> |
30 |
|
31 |
remote: 8833535ff8f041d308284149193f5c7322b37b26: no GCO sign-off |
32 |
present |
33 |
remote: e034098e139484cddd1614b55b844898190b21d6: no GCO sign-off |
34 |
present |
35 |
remote: a1c64ac2ac71ef2291d472318d5ffc2218800cd4: no GCO sign-off |
36 |
present |
37 |
remote: 1e846c6372d629171b16282db5ce644577a991fc: no GCO sign-off |
38 |
present |
39 |
remote: e567d8374ec8cbb6f79ac1a3ceef3c71de529d6e: no GCO sign-off |
40 |
present |
41 |
remote: 6131f30065fbff4a50259b81b4e9e88b2ad03661: no GCO sign-off |
42 |
present |
43 |
|
44 |
Please: |
45 |
|
46 |
0a) Explain to me how to fix my commits that I now can't push, or |
47 |
0b) disable that hook immediately. |
48 |
1) Update repoman to enforce it _before_ the commit is executed. |
49 |
2) Wait for the repoman update to trickle down to all developers. |
50 |
3) Announce it ahead of time. |
51 |
4) Re-enable the hook. |