| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA256 |
| 3 |
|
| 4 |
On 21/11/15 06:29 PM, NP-Hardass wrote: |
| 5 |
> Probably not the ideal solution given that you seem to prefer |
| 6 |
> removal of such variables, but a REPODIR variable which is set to |
| 7 |
> the directory where the repo is (basically making PORTDIR dynamic |
| 8 |
> and setting it on a per package basis) could enable developers |
| 9 |
> to reference their repo when needed, allowing variable use in a |
| 10 |
> multi repo system. Additionally, if that idea is liked, I think |
| 11 |
> an array of the repos masters and/or their dirs (or some |
| 12 |
> functions to access that information) could also be useful. Like |
| 13 |
> get_masters and get_repo_dir functions. |
| 14 |
> |
| 15 |
|
| 16 |
- From your description here REPODIR would only point to the current |
| 17 |
repo, so for licence-file access when the license is in the main |
| 18 |
gentoo repo, but the current repo is an overlay, it would still fail. |
| 19 |
|
| 20 |
Similar cases could occur for eclasses, especially since 'masters' |
| 21 |
in repo metadata allows multiple repos to be chained. |
| 22 |
|
| 23 |
All told, I think i'm in favour of banning the variables, and |
| 24 |
potentially providing getter functions that would output the path of |
| 25 |
these files if they need to be accessed -- '$(get_eclasspath |
| 26 |
[name])' or $(get_licensepath [name]) or the like. I don't know if |
| 27 |
these could be implemented in-eclass or if they would be something |
| 28 |
that would have to be added to EAPI7..? |
| 29 |
|
| 30 |
|
| 31 |
|
| 32 |
-----BEGIN PGP SIGNATURE----- |
| 33 |
Version: GnuPG v2 |
| 34 |
|
| 35 |
iF4EAREIAAYFAlZRAu4ACgkQAJxUfCtlWe1r4wEA3bnt0LtExuJCFTFMzZfzoTgl |
| 36 |
q+T0eEPvKw0HK3De9rsA/iZZlZ0VKBTErx7mXk4YjiykN9Ruk/ZswkDDSGWM29IW |
| 37 |
=JEGh |
| 38 |
-----END PGP SIGNATURE----- |
Archives